Skip to content

Commit ab553fb

Browse files
committed
[bb] fix PR selector when not authed
1 parent 541a32a commit ab553fb

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/button/button-contributions.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -410,8 +410,9 @@ export const buttonContributions: ButtonContributionParams[] = [
410410
exampleUrls: [
411411
// "https://bitbucket.org/efftinge/browser-extension-test/pull-requests/1"
412412
],
413-
selector: 'xpath://*[@id="main"]/div/div/div[1]/div/div/div[1]/div/div[2]/div/div[2]/div/div/div[1]/div', // section with the "Request changes" and "Approve" buttons
413+
selector: 'xpath://*[@id="main"]/div/div/div[1]/div/div/div[1]/div/div[2]/div/div[2]/div/div', // grandparent div of the "Request changes" and "Approve" buttons
414414
containerElement: createElement("div", {}),
415+
insertBefore: 'xpath:(//*[@id="main"]/div/div/div[1]/div/div/div[1]/div/div[2]/div/div[2]/div/div/div)[last()]', // note the [last()] to insert before the last child (the kebab menu)
415416
application: "bitbucket",
416417
},
417418
{

test/src/button-contributions-copy.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -410,8 +410,9 @@ export const buttonContributions: ButtonContributionParams[] = [
410410
exampleUrls: [
411411
// "https://bitbucket.org/efftinge/browser-extension-test/pull-requests/1"
412412
],
413-
selector: 'xpath://*[@id="main"]/div/div/div[1]/div/div/div[1]/div/div[2]/div/div[2]/div/div/div[1]/div', // section with the "Request changes" and "Approve" buttons
413+
selector: 'xpath://*[@id="main"]/div/div/div[1]/div/div/div[1]/div/div[2]/div/div[2]/div/div', // grandparent div of the "Request changes" and "Approve" buttons
414414
containerElement: createElement("div", {}),
415+
insertBefore: 'xpath:(//*[@id="main"]/div/div/div[1]/div/div/div[1]/div/div[2]/div/div[2]/div/div/div)[last()]', // note the [last()] to insert before the last child (the kebab menu)
415416
application: "bitbucket",
416417
},
417418
{

0 commit comments

Comments
 (0)