change condition for adding terminal completion executables (microsoft#235994)

meganrogge · web-flow · commit 1bf794addace · 2024-12-12T12:13:41.000-08:00
fix microsoft#235082
diff --git a/extensions/terminal-suggest/src/terminalSuggestMain.ts b/extensions/terminal-suggest/src/terminalSuggestMain.ts
@@ -187,7 +187,7 @@ async function getCommandsInPath(): Promise<Set<string> | undefined> {
 			const files = await vscode.workspace.fs.readDirectory(vscode.Uri.file(path));
 
 			for (const [file, fileType] of files) {
-				if (fileType === vscode.FileType.File || fileType === vscode.FileType.SymbolicLink) {
+				if (fileType !== vscode.FileType.Unknown && fileType !== vscode.FileType.Directory) {
 					executables.add(file);
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ async function getCommandsInPath(): Promise<Set<string> \| undefined> {`
`187`	`187`	`const files = await vscode.workspace.fs.readDirectory(vscode.Uri.file(path));`
`188`	`188`
`189`	`189`	`for (const [file, fileType] of files) {`
`190`		`- if (fileType === vscode.FileType.File \|\| fileType === vscode.FileType.SymbolicLink) {`
	`190`	`+ if (fileType !== vscode.FileType.Unknown && fileType !== vscode.FileType.Directory) {`
`191`	`191`	`executables.add(file);`
`192`	`192`	`}`
`193`	`193`	`}`