Skip to content

Commit 1d500fb

Browse files
authored
Add CodeActionKind.RefactorMove (microsoft#160730)
Fixes microsoft#160728
1 parent 76f3be0 commit 1d500fb

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

extensions/typescript-language-features/src/languageFeatures/refactor.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ const Extract_Interface = Object.freeze<CodeActionKind>({
135135
});
136136

137137
const Move_NewFile = Object.freeze<CodeActionKind>({
138-
kind: vscode.CodeActionKind.Refactor.append('move').append('newFile'),
138+
kind: vscode.CodeActionKind.RefactorMove.append('newFile'),
139139
matches: refactor => refactor.name.startsWith('Move to a new file')
140140
});
141141

extensions/vscode-api-tests/src/singlefolder-tests/types.test.ts

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ suite('vscode API - types', () => {
2020
assert.ok(vscode.CodeActionKind.Refactor instanceof vscode.CodeActionKind);
2121
assert.ok(vscode.CodeActionKind.RefactorExtract instanceof vscode.CodeActionKind);
2222
assert.ok(vscode.CodeActionKind.RefactorInline instanceof vscode.CodeActionKind);
23+
assert.ok(vscode.CodeActionKind.RefactorMove instanceof vscode.CodeActionKind);
2324
assert.ok(vscode.CodeActionKind.RefactorRewrite instanceof vscode.CodeActionKind);
2425
assert.ok(vscode.CodeActionKind.Source instanceof vscode.CodeActionKind);
2526
assert.ok(vscode.CodeActionKind.SourceOrganizeImports instanceof vscode.CodeActionKind);

src/vs/workbench/api/common/extHostTypes.ts

+2
Original file line numberDiff line numberDiff line change
@@ -1321,6 +1321,7 @@ export class CodeActionKind {
13211321
public static Refactor: CodeActionKind;
13221322
public static RefactorExtract: CodeActionKind;
13231323
public static RefactorInline: CodeActionKind;
1324+
public static RefactorMove: CodeActionKind;
13241325
public static RefactorRewrite: CodeActionKind;
13251326
public static Source: CodeActionKind;
13261327
public static SourceOrganizeImports: CodeActionKind;
@@ -1347,6 +1348,7 @@ CodeActionKind.QuickFix = CodeActionKind.Empty.append('quickfix');
13471348
CodeActionKind.Refactor = CodeActionKind.Empty.append('refactor');
13481349
CodeActionKind.RefactorExtract = CodeActionKind.Refactor.append('extract');
13491350
CodeActionKind.RefactorInline = CodeActionKind.Refactor.append('inline');
1351+
CodeActionKind.RefactorMove = CodeActionKind.Refactor.append('move');
13501352
CodeActionKind.RefactorRewrite = CodeActionKind.Refactor.append('rewrite');
13511353
CodeActionKind.Source = CodeActionKind.Empty.append('source');
13521354
CodeActionKind.SourceOrganizeImports = CodeActionKind.Source.append('organizeImports');

src/vscode-dts/vscode.d.ts

+12-1
Original file line numberDiff line numberDiff line change
@@ -2275,6 +2275,18 @@ declare module 'vscode' {
22752275
*/
22762276
static readonly RefactorInline: CodeActionKind;
22772277

2278+
/**
2279+
* Base kind for refactoring move actions: `refactor.move`
2280+
*
2281+
* Example move actions:
2282+
*
2283+
* - Move a function to a new file
2284+
* - Move a property between classes
2285+
* - Move method to base class
2286+
* - ...
2287+
*/
2288+
static readonly RefactorMove: CodeActionKind;
2289+
22782290
/**
22792291
* Base kind for refactoring rewrite actions: `refactor.rewrite`
22802292
*
@@ -2284,7 +2296,6 @@ declare module 'vscode' {
22842296
* - Add or remove parameter
22852297
* - Encapsulate field
22862298
* - Make method static
2287-
* - Move method to base class
22882299
* - ...
22892300
*/
22902301
static readonly RefactorRewrite: CodeActionKind;

0 commit comments

Comments
 (0)