Skip to content

Commit 747bb0a

Browse files
committed
fix: upgrade to compatible react-native-code-push
1 parent 17cbc2c commit 747bb0a

File tree

4 files changed

+320
-216
lines changed

4 files changed

+320
-216
lines changed

android/app/build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ project.ext.react = [
8686

8787
apply from: "../../node_modules/react-native/react.gradle"
8888
apply from: "../../node_modules/react-native-vector-icons/fonts.gradle"
89-
// apply from: "../../node_modules/react-native-code-push/android/codepush.gradle"
89+
apply from: "../../node_modules/react-native-code-push/android/codepush.gradle"
9090
apply from: project(':react-native-config').projectDir.getPath() + "/dotenv.gradle"
9191

9292
/**
@@ -155,7 +155,7 @@ dependencies {
155155
compile project(':react-native-i18n')
156156
// compile project(':react-native-photo-view')
157157
compile project(':react-native-config')
158-
// compile project(':react-native-code-push')
158+
compile project(':react-native-code-push')
159159
compile project(':react-native-device-info')
160160
implementation fileTree(dir: "libs", include: ["*.jar"])
161161
implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"

android/app/src/main/java/com/gitpoint/MainApplication.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import com.AlexanderZaytsev.RNI18n.RNI18nPackage;
1010
// import com.reactnative.photoview.PhotoViewPackage;
1111
import com.lugg.ReactNativeConfig.ReactNativeConfigPackage;
12-
// import com.microsoft.codepush.react.CodePush;
12+
import com.microsoft.codepush.react.CodePush;
1313
import com.learnium.RNDeviceInfo.RNDeviceInfo;
1414
import com.oblador.vectoricons.VectorIconsPackage;
1515
import com.facebook.react.ReactNativeHost;
@@ -24,10 +24,10 @@ public class MainApplication extends Application implements ReactApplication {
2424

2525
private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
2626

27-
// @Override
28-
// protected String getJSBundleFile() {
29-
// return CodePush.getJSBundleFile();
30-
// }
27+
@Override
28+
protected String getJSBundleFile() {
29+
return CodePush.getJSBundleFile();
30+
}
3131

3232
@Override
3333
public boolean getUseDeveloperSupport() {
@@ -44,7 +44,7 @@ protected List<ReactPackage> getPackages() {
4444
new RNI18nPackage(),
4545
// new PhotoViewPackage(),
4646
new ReactNativeConfigPackage(),
47-
// new CodePush(BuildConfig.CODEPUSH_ANDROID_DEPLOYMENT_KEY, MainApplication.this, BuildConfig.DEBUG),
47+
new CodePush(BuildConfig.CODEPUSH_ANDROID_DEPLOYMENT_KEY, MainApplication.this, BuildConfig.DEBUG),
4848
new RNDeviceInfo(),
4949
new VectorIconsPackage()
5050
);

android/settings.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ project(':react-native-i18n').projectDir = new File(rootProject.projectDir, '../
1111
// project(':react-native-photo-view').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-photo-view/android')
1212
include ':react-native-config'
1313
project(':react-native-config').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-config/android')
14-
// include ':react-native-code-push'
15-
// project(':react-native-code-push').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-code-push/android/app')
14+
include ':react-native-code-push'
15+
project(':react-native-code-push').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-code-push/android/app')
1616
include ':react-native-device-info'
1717
project(':react-native-device-info').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-device-info/android')
1818
include ':react-native-vector-icons'

0 commit comments

Comments
 (0)