-
-
Notifications
You must be signed in to change notification settings - Fork 607
When moving to source view full screen please allow left arrow to go back #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I believe that worked prior to v0.23.0. |
I recently updated to v0.23 and this feels very frustrating to me. I'll try to take up this issue later today and temporarily roll back to v0.22.x on my machine until a new release is made. |
I am also not a fan of the current solution but the big UX fail that comes with allowing Screenflick.Movie.5.mp4hope someone has an idea how to solve this. one idea (also not great) is to open the full-screen diff with a separate key press and not via |
To me, restoring the old functionality but allowing a full-screen diff with a dedicated keybind sounds like a good solution. I've been using the v0.23 release lately but I still find the old behavior of resizing the diff view more ergonomic. Another solution would be to allow word-wrapping which removes the need for scrolling altogether. Wrapped lines could be shown by putting a |
Word-wrapping seems to be a good solution. Another possible approach - scroll the diff viewer only with vim-like |
I'm not a big fan of Perhaps we can only allow key-repeat when scrolling and require a new keypress to exit out of the view. |
unfortunately terminals do not allow that distinction |
I want to discuss the initial question about this issue. |
It seems like #1955 is relevant here — the distinction between diff-as-pane (in the status view) and fullscreen diff seems important for usability. In my opinion a good usability guideline for arrow key navigation is: If you can ENTER a mode with right arrow, you should be able to EXIT it with left arrow. It seems like there are a few ways to fix this:
Pseudocode for option 3:
|
I want to add my 2cents on the issue: I am still using v0.22 because I strongly feel that moving to the diff panel should not automatically make it full screen. Also, as already said, "If you can ENTER a mode with right arrow, you should be able to EXIT it with left arrow" Anyway gitui is amazing thanks for making it happen |
yeah please make it happen this breaks the otherwise amazing workflow |
Is your feature request related to a problem? Please describe.
In "Status [1]" tab, you can navigate right to the source code with right arrow. But then you have to hit escape to navigate back left.
Describe the solution you'd like
Please make left arrow navigate left.
Describe alternatives you've considered
Escape.
Additional context

now I click "right arrow"
Now I can't go back left with left arrow. Only with Escape I can go back.
Thank you for gitui it is amazing.
The text was updated successfully, but these errors were encountered: