Skip to content

Return non-zero exit code if unable to start #35

@manics

Description

@manics

omero-ms-image-region should exit with a non-zero status is an error is encountered during startup, e.g. invalid configuration, or invalid command line arguments. Currently (afec676) it exits with 0 implying success:

omero-ms@531b71dba100:~/omero-ms-image-region/bin$ ./omero-ms-image-region --invalid-args
2019-07-01 16:59:38,683 [vert.x-eventloop-thread-0] INFO  c.g.o.m.i.r.ImageRegionMicroserviceVerticle - Starting verticle
2019-07-01 16:59:38,989 [vert.x-eventloop-thread-0] INFO  c.g.o.m.i.r.ImageRegionMicroserviceVerticle - Deploying verticle
java.lang.IllegalArgumentException: 'omero.server' block missing from configuration
        at com.glencoesoftware.omero.ms.image.region.ImageRegionMicroserviceVerticle.deploy(ImageRegionMicroserviceVerticle.java:132)
        at com.glencoesoftware.omero.ms.image.region.ImageRegionMicroserviceVerticle$1.handle(ImageRegionMicroserviceVerticle.java:113)
        at com.glencoesoftware.omero.ms.image.region.ImageRegionMicroserviceVerticle$1.handle(ImageRegionMicroserviceVerticle.java:109)
        at io.vertx.config.impl.ConfigRetrieverImpl.lambda$getConfig$2(ConfigRetrieverImpl.java:180)
        at io.vertx.config.impl.ConfigRetrieverImpl.lambda$compute$9(ConfigRetrieverImpl.java:294)
        at io.vertx.core.impl.CompositeFutureImpl.lambda$all$1(CompositeFutureImpl.java:49)
        at io.vertx.core.impl.FutureImpl.tryComplete(FutureImpl.java:125)
        at io.vertx.config.impl.ConfigRetrieverImpl.lambda$null$6(ConfigRetrieverImpl.java:264)
        at io.vertx.config.impl.ConfigurationProvider.lambda$get$1(ConfigurationProvider.java:66)
        at io.vertx.core.impl.ContextImpl.lambda$null$0(ContextImpl.java:284)
        at io.vertx.core.impl.ContextImpl.executeTask(ContextImpl.java:320)
        at io.vertx.core.impl.EventLoopContext.lambda$executeAsync$0(EventLoopContext.java:38)
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:462)
        at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:897)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:834)
2019-07-01 16:59:39,014 [vert.x-eventloop-thread-1] ERROR i.v.c.i.l.c.VertxIsolatedDeployer - Failed in deploying verticle
java.lang.IllegalArgumentException: 'omero.server' block missing from configuration
        at com.glencoesoftware.omero.ms.image.region.ImageRegionMicroserviceVerticle.deploy(ImageRegionMicroserviceVerticle.java:132)
        at com.glencoesoftware.omero.ms.image.region.ImageRegionMicroserviceVerticle$1.handle(ImageRegionMicroserviceVerticle.java:113)
        at com.glencoesoftware.omero.ms.image.region.ImageRegionMicroserviceVerticle$1.handle(ImageRegionMicroserviceVerticle.java:109)
        at io.vertx.config.impl.ConfigRetrieverImpl.lambda$getConfig$2(ConfigRetrieverImpl.java:180)
        at io.vertx.config.impl.ConfigRetrieverImpl.lambda$compute$9(ConfigRetrieverImpl.java:294)
        at io.vertx.core.impl.CompositeFutureImpl.lambda$all$1(CompositeFutureImpl.java:49)
        at io.vertx.core.impl.FutureImpl.tryComplete(FutureImpl.java:125)
        at io.vertx.config.impl.ConfigRetrieverImpl.lambda$null$6(ConfigRetrieverImpl.java:264)
        at io.vertx.config.impl.ConfigurationProvider.lambda$get$1(ConfigurationProvider.java:66)
        at io.vertx.core.impl.ContextImpl.lambda$null$0(ContextImpl.java:284)
        at io.vertx.core.impl.ContextImpl.executeTask(ContextImpl.java:320)
        at io.vertx.core.impl.EventLoopContext.lambda$executeAsync$0(EventLoopContext.java:38)
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:462)
        at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:897)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:834)
java.lang.IllegalArgumentException: 'omero.server' block missing from configuration
        at com.glencoesoftware.omero.ms.image.region.ImageRegionMicroserviceVerticle.deploy(ImageRegionMicroserviceVerticle.java:132)
        at com.glencoesoftware.omero.ms.image.region.ImageRegionMicroserviceVerticle$1.handle(ImageRegionMicroserviceVerticle.java:113)
        at com.glencoesoftware.omero.ms.image.region.ImageRegionMicroserviceVerticle$1.handle(ImageRegionMicroserviceVerticle.java:109)
        at io.vertx.config.impl.ConfigRetrieverImpl.lambda$getConfig$2(ConfigRetrieverImpl.java:180)
        at io.vertx.config.impl.ConfigRetrieverImpl.lambda$compute$9(ConfigRetrieverImpl.java:294)
        at io.vertx.core.impl.CompositeFutureImpl.lambda$all$1(CompositeFutureImpl.java:49)
        at io.vertx.core.impl.FutureImpl.tryComplete(FutureImpl.java:125)
        at io.vertx.config.impl.ConfigRetrieverImpl.lambda$null$6(ConfigRetrieverImpl.java:264)
        at io.vertx.config.impl.ConfigurationProvider.lambda$get$1(ConfigurationProvider.java:66)
        at io.vertx.core.impl.ContextImpl.lambda$null$0(ContextImpl.java:284)
        at io.vertx.core.impl.ContextImpl.executeTask(ContextImpl.java:320)
        at io.vertx.core.impl.EventLoopContext.lambda$executeAsync$0(EventLoopContext.java:38)
        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:462)
        at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:897)
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:834)
omero-ms@531b71dba100:~/omero-ms-image-region/bin$ echo $?
0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions