Strict check for expected value in 'assertPromiseFulfills'

glesys · Jan 14, 2021 · 73b946d · 73b946d
1 parent 6af401c
commit 73b946d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+- **BREAKING**: Strict check for expected value in `assertPromiseFulfills`.
 
 ## [4.0.0] - 2020-12-10
 

diff --git a/src/Concerns/AssertsPromises.php b/src/Concerns/AssertsPromises.php
@@ -38,7 +38,7 @@ public function assertPromiseFulfills($promise, $expectedValue = null): void
         }
 
         if (! is_null($expectedValue)) {
-            $this->assertEquals(
+            $this->assertSame(
                 $expectedValue,
                 $result,
                 'Failed asserting that promise fulfills with a specified value.'

diff --git a/tests/AssertsPromisesTest.php b/tests/AssertsPromisesTest.php
@@ -65,7 +65,7 @@ public function test_assertPromiseFulfills_fails_on_unexpected_result()
         } catch (Exception $exception) {
             $this->assertEquals(
                 "Failed asserting that promise fulfills with a specified value.\n" .
-                "Failed asserting that 4 matches expected 5.",
+                "Failed asserting that 4 is identical to 5.",
                 $exception->getMessage()
             );
             return;