fix: Reset target id after loading saved state

Author: g-bougard

Changes

@@ -4,6 +4,8 @@ Revision history for GLPI agent
 
 core:
 * On windows, permit to use libxml2 built libraries in different threads
+* Reset target id after loading saved state to avoir re-using same id after a
+  target configuration update
 
 inventory:
 * PR #931: Added DrWeb & Karpersky Endpoint for Linux antivirus support on linux

lib/GLPI/Agent/Target.pm

@@ -43,12 +43,6 @@ sub _init {
 
     my $logger = $self->{logger};
 
-    # target identity
-    $self->{id} = $params{id};
-
-    # Initialize logger prefix
-    $self->{_logprefix} = "[target $self->{id}]";
-
     $self->{storage} = GLPI::Agent::Storage->new(
         logger    => $self->{logger},
         oldvardir => $params{oldvardir} // "",
@@ -60,6 +54,12 @@ sub _init {
     # handle persistent state
     $self->_loadState();
 
+    # Always reset target identity to avoid reusing if after a target reconfiguration
+    $self->{id} = $params{id};
+
+    # Initialize logger prefix after id has been eventually reset
+    $self->{_logprefix} = "[target $self->{id}]";
+
     # Update maxDelay from provided config when not a server
     unless ($self->isType('server')) {
         $self->setMaxDelay($keepMaxDelay);