build: Always call finalize() after initialize() in ca.dll

g-bougard · g-bougard · commit 4055d12da83c · 2024-04-08T17:34:05.000+02:00
Just in case initialize() can fail in the future
diff --git a/contrib/windows/packaging/tools/ca/dll/customaction.cpp b/contrib/windows/packaging/tools/ca/dll/customaction.cpp
@@ -44,7 +44,7 @@ extern "C" UINT WINAPI CheckElevatedCustomAction(MSIHANDLE hInstall)
     hr = initialize(hInstall, "CheckElevatedCustomACtion");
     if (FAILED(hr))
     {
-        return ERROR_INSTALL_FAILURE;
+        return finalize(ERROR_INSTALL_FAILURE);
     }
 
     hr = CheckIfCurrentProcIsElevated(&bElevated);

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ extern "C" UINT WINAPI CheckElevatedCustomAction(MSIHANDLE hInstall)`
`44`	`44`	`hr = initialize(hInstall, "CheckElevatedCustomACtion");`
`45`	`45`	`if (FAILED(hr))`
`46`	`46`	`{`
`47`		`- return ERROR_INSTALL_FAILURE;`
	`47`	`+ return finalize(ERROR_INSTALL_FAILURE);`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`hr = CheckIfCurrentProcIsElevated(&bElevated);`