phpstan level 5 (#650)

* phpstan level 5

* Fix phpstan

* Typo, indent, typehint

Author: trasher

inc/deployfile.class.php

@@ -64,7 +64,7 @@ public function getTypes()
          'Computer' => __("Upload from computer", 'glpiinventory')
         ];
 
-        if (GLPI_INSTALL_MODE !== 'CLOUD') {
+        if (GLPI_INSTALL_MODE !== 'CLOUD') { //@phpstan-ignore-line
             $types['Server'] = __("Upload from server", 'glpiinventory');
         }
 

inc/task.class.php

@@ -879,7 +879,7 @@ public function getJoblogs(array $task_ids = [], $with_logs = true, $only_active
 
         if (count($data_structure['result']) <= 0) {
             // Not useful to go further, we will not have any result to send!
-            // Perharps the required tasks are not even active ;)
+            // Perhaps the required tasks are not even active ;)
             return ['tasks' => $logs, 'agents' => $agents];
         }
 
@@ -905,28 +905,29 @@ public function getJoblogs(array $task_ids = [], $with_logs = true, $only_active
                 "Job: " . print_r($result, true)
             );
 
-            $task_id = $result['task_id'];
+            $task_id = (int)$result['task_id'];
             if (!array_key_exists($task_id, $logs)) {
                 $logs[$task_id] = [
-                 'task_name' => $result['task_name'],
-                 'task_id'   => $result['task_id'],
-                 'expanded'  => false,
-                 'jobs'      => []
+                    'task_name' => $result['task_name'],
+                    'task_id'   => $result['task_id'],
+                    'expanded'  => false,
+                    'jobs'      => []
                 ];
             }
 
             if (isset($expanded[$task_id])) {
                 $logs[$task_id]['expanded'] = $expanded[$task_id];
             }
 
-            $job_id = $result['job_id'];
+            $job_id = (int)$result['job_id'];
+            /** @var array  $jobs_handle */
             $jobs_handle = &$logs[$task_id]['jobs'];
             if (!isset($jobs_handle[$job_id])) {
                 $jobs_handle[$job_id] = [
-                'name'    => $result['job_name'],
-                'id'      => $result['job_id'],
-                'method'  => $result['job_method'],
-                'targets' => []
+                    'name'    => $result['job_name'],
+                    'id'      => $result['job_id'],
+                    'method'  => $result['job_method'],
+                    'targets' => []
                 ];
             }
             $targets = importArrayFromDB($result['job_targets']);
@@ -1090,6 +1091,7 @@ public function getJoblogs(array $task_ids = [], $with_logs = true, $only_active
                     continue;
                 }
                 $job_id = (int)$taskjob['id'];
+                /** @var array $jobs */
                 $jobs   = &$logs[$task_id]['jobs'];
                 if (!isset($jobs[$job_id])) {
                     continue;
@@ -1265,7 +1267,9 @@ public function getJoblogs(array $task_ids = [], $with_logs = true, $only_active
                      $run_id = $log_result['run_id'];
                      $run_data = $runs_id[$run_id];
 
+                     /** @var array $jobs */
                      $jobs    = &$logs[$run_data['task_id']]['jobs'];
+                     /** @var array $targets */
                      $targets = &$jobs[$run_data['jobs_id']]['targets'];
 
                      $targets[$run_data['target_id']]['agents'][$run_data['agent_id']][] = [

phpstan.neon

@@ -1,7 +1,7 @@
 parameters:
     parallel:
         maximumNumberOfProcesses: 2
-    level: 2
+    level: 5
     bootstrapFiles:
         - ../../inc/based_config.php
         - setup.php