-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase MAX_AVAILABLE_MARKETS to consider more markets #620
Conversation
WalkthroughThis pull request updates a constant in the agent deployment script by changing the value of Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Currently, we ask some agents to bet on 20 markets per run. However, because we fetch only 20 markets to consider, most of them are skipped, because there is already a bet from the previous 24 hours!
So, for example
DeployablePredictionProphetGPT4oAgent
, instead of betting on around 240 markets per day, it processes only 76.This limit on fetched markets was previously used, because in the old implementation, agent would first filter out predictable markets, and then place bets on subset of them. So verifying 1000 markets would be inefficient, but now as the agent is doing it on-the-go, it should be OK.
Instead of having huge number of fetched markets, we could paginate in batches and fetch next batch only if needed. But that needs some serious refactor. @coderabbitai Please create an issue for that.