Skip to content

Commit 7ff7e6e

Browse files
committed
fix(ci): Add zero check in getNextPriceAmount0Remove function
1 parent 1966daf commit 7ff7e6e

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

contract/p/gnoswap/gnsmath/sqrt_price_math.gno

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ func getNextPriceAmount0Add(
5454
func getNextPriceAmount0Remove(
5555
currentSqrtPriceX96, liquidity, amountToRemove *u256.Uint,
5656
) *u256.Uint {
57+
if amountToRemove.IsZero() {
58+
panic(errInvalidPoolSqrtPrice)
59+
}
60+
5761
// liquidityShifted = liquidity << 96
5862
liquidityShifted := u256.Zero().Lsh(liquidity, Q96_RESOLUTION)
5963
// amountTimesSqrtPrice = amountToRemove * currentSqrtPriceX96

contract/p/gnoswap/gnsmath/sqrt_price_math_test.gno

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,14 @@ func TestSqrtPriceMath_getNextPriceAmount0Remove(t *testing.T) {
207207
shouldPanic: true,
208208
panicMsg: errInvalidPoolSqrtPrice.Error(),
209209
},
210+
{
211+
name: "zero_amount_panics",
212+
current: u256.Zero(),
213+
liquidity: u256.NewUint(6416),
214+
amountToRemove: u256.Zero(),
215+
shouldPanic: true,
216+
panicMsg: errInvalidPoolSqrtPrice.Error(),
217+
},
210218
}
211219

212220
for _, tt := range tests {

0 commit comments

Comments
 (0)