refactor: resolve internal review

Author: r3v4s

contract/p/gnoswap/consts/consts.gno

@@ -112,11 +112,11 @@ const (
 
 // TIMESTAMP & DAY
 const (
-	SECOND_IN_MILLISECOND = 1000
+	MILLISECONDS_PER_SECOND = 1000
 
 	// in seconds
-	TIMESTAMP_DAY  = 86400
-	TIMESTAMP_YEAR = 31536000
+	SECONDS_PER_DAY = 86400
+	TIMESTAMP_YEAR  = 31536000
 
 	DAY_PER_YEAR = 365
 )

contract/r/gnoswap/common/tick_math.gno

@@ -15,7 +15,6 @@ var (
 	binaryLogTree = NewBinaryLogTree()
 
 	shift1By32Left = u256.MustFromDecimal("4294967296") // (1 << 32)
-	maxTick        = int32(887272)
 )
 
 // TreeValue wraps u256.Uint to implement custom value type for avl.Tree
@@ -356,7 +355,7 @@ func abs(x int32) int32 {
 
 // assertValidTickRange validates that the absolute tick value is within the acceptable range.
 func assertValidTickRange(absTick int32) {
-	if absTick > maxTick {
+	if absTick > consts.MAX_TICK {
 		panic(newErrorWithDetail(
 			errOutOfRange,
 			ufmt.Sprintf("abs tick is out of range (larger than 887272), abs tick: %d", absTick),

contract/r/gnoswap/gnft/gnft.gno

@@ -248,12 +248,7 @@ func SetApprovalForAll(operator std.Address, approved bool) error {
 //   - std.Address: The address approved to manage the token. Returns an empty address if no approval exists.
 //   - error: Returns an error if the lookup fails or the token ID is invalid.
 func GetApproved(tid grc721.TokenID) (std.Address, error) {
-	addr, err := gnft.GetApproved(tid)
-	if err != nil {
-		return "", err
-	}
-
-	return addr, nil
+	return gnft.GetApproved(tid)
 }
 
 // IsApprovedForAll checks if an operator is approved to manage all tokens of an owner.

contract/r/gnoswap/gns/halving.gno

@@ -44,9 +44,9 @@ var (
 
 var (
 	blockPerYear = consts.TIMESTAMP_YEAR / consts.BLOCK_GENERATION_INTERVAL
-	blockPerDay  = consts.TIMESTAMP_DAY / consts.BLOCK_GENERATION_INTERVAL
+	blockPerDay  = consts.SECONDS_PER_DAY / consts.BLOCK_GENERATION_INTERVAL
 
-	avgBlockTimeMs int64 = consts.SECOND_IN_MILLISECOND * consts.BLOCK_GENERATION_INTERVAL
+	avgBlockTimeMs int64 = consts.MILLISECONDS_PER_SECOND * consts.BLOCK_GENERATION_INTERVAL
 	perBlockMint         = avl.NewTree() // height => uint64
 )
 
@@ -425,7 +425,7 @@ func setAvgBlockTimeInMs(ms int64) {
 
 		yearEndTimestamp := GetHalvingYearTimestamp(year) + consts.TIMESTAMP_YEAR
 		timeLeftForYear := yearEndTimestamp - now
-		numBlock := (timeLeftForYear * consts.SECOND_IN_MILLISECOND) / ms
+		numBlock := (timeLeftForYear * consts.MILLISECONDS_PER_SECOND) / ms
 		yearEndHeight := height + numBlock
 
 		if year == currentYear {

contract/r/gnoswap/gns/utils.gno

@@ -58,7 +58,7 @@ func i64Min(x, y int64) int64 {
 }
 
 func secToMs(sec int64) int64 {
-	return sec * consts.SECOND_IN_MILLISECOND
+	return sec * consts.MILLISECONDS_PER_SECOND
 }
 
 func formatUint(v interface{}) string {

contract/r/gnoswap/gov/staker/clean_delegation_stat_history.gno

@@ -7,7 +7,7 @@ import (
 )
 
 // default one day
-var thresholdVotingWeightBlockHeight = consts.TIMESTAMP_DAY / consts.BLOCK_GENERATION_INTERVAL
+var thresholdVotingWeightBlockHeight = consts.SECONDS_PER_DAY / consts.BLOCK_GENERATION_INTERVAL
 
 var (
 	lastCleanedHeight uint64 = 0

contract/r/gnoswap/launchpad/launchpad.gno

@@ -632,7 +632,7 @@ func createTier(
 		time:   startTime,
 	}
 
-	durationSecond := duration * TIMESTAMP_DAY
+	durationSecond := duration * consts.SECONDS_PER_DAY
 	endTime := startTime + durationSecond
 	durationHeight := convertTimeToHeight(durationSecond)
 	endHeight := startHeight + durationHeight