Skip to content

Commit c9ebc09

Browse files
committed
namedotcom: follow CNAME
1 parent b83c1d5 commit c9ebc09

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

providers/dns/namedotcom/namedotcom.go

+8-4
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,10 @@ func NewDNSProviderConfig(config *Config) (*DNSProvider, error) {
110110
func (d *DNSProvider) Present(domain, token, keyAuth string) error {
111111
info := dns01.GetChallengeInfo(domain, keyAuth)
112112

113-
// TODO(ldez) replace domain by FQDN to follow CNAME.
113+
if info.EffectiveFQDN != info.FQDN {
114+
domain = dns01.UnFqdn(info.EffectiveFQDN)
115+
}
116+
114117
domainDetails, err := d.client.GetDomain(&namecom.GetDomainRequest{DomainName: domain})
115118
if err != nil {
116119
return fmt.Errorf("namedotcom: API call failed: %w", err)
@@ -121,7 +124,6 @@ func (d *DNSProvider) Present(domain, token, keyAuth string) error {
121124
return fmt.Errorf("namedotcom: %w", err)
122125
}
123126

124-
// TODO(ldez) replace domain by FQDN to follow CNAME.
125127
request := &namecom.Record{
126128
DomainName: domain,
127129
Host: subDomain,
@@ -142,15 +144,17 @@ func (d *DNSProvider) Present(domain, token, keyAuth string) error {
142144
func (d *DNSProvider) CleanUp(domain, token, keyAuth string) error {
143145
info := dns01.GetChallengeInfo(domain, keyAuth)
144146

145-
// TODO(ldez) replace domain by FQDN to follow CNAME.
147+
if info.EffectiveFQDN != info.FQDN {
148+
domain = dns01.UnFqdn(info.EffectiveFQDN)
149+
}
150+
146151
records, err := d.getRecords(domain)
147152
if err != nil {
148153
return fmt.Errorf("namedotcom: %w", err)
149154
}
150155

151156
for _, rec := range records {
152157
if rec.Fqdn == info.EffectiveFQDN && rec.Type == "TXT" {
153-
// TODO(ldez) replace domain by FQDN to follow CNAME.
154158
request := &namecom.DeleteRecordRequest{
155159
DomainName: domain,
156160
ID: rec.ID,

0 commit comments

Comments
 (0)