Skip to content

Commit cd7257f

Browse files
authored
winarm64: remove experimental build tags (#4176)
* winarm64: remove experimental build tags * update faq
1 parent 4b670ea commit cd7257f

File tree

7 files changed

+3
-15
lines changed

7 files changed

+3
-15
lines changed

Documentation/faq.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ Currently Delve supports (GOOS / GOARCH):
1717
* linux / arm64 (AARCH64)
1818
* linux / 386
1919
* windows / amd64
20+
* windows / arm64
2021
* darwin (macOS) / amd64
2122

2223
There is no planned ETA for support of other architectures or operating systems. Bugs tracking requested support are:

_scripts/gen-capslock-all.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var platforms = []Platform{
2626
{GOOS: "darwin", GOARCH: "amd64"},
2727
{GOOS: "darwin", GOARCH: "arm64"},
2828
{GOOS: "windows", GOARCH: "amd64"},
29-
{GOOS: "windows", GOARCH: "arm64", BuildTags: "exp.winarm64"},
29+
{GOOS: "windows", GOARCH: "arm64"},
3030
}
3131

3232
const (

_scripts/make.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -305,9 +305,6 @@ func tagFlags(isTest bool) string {
305305
tags = append(tags, mactags)
306306
}
307307
if isTest {
308-
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
309-
tags = append(tags, "exp.winarm64")
310-
}
311308
if runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le" {
312309
tags = append(tags, "exp.linuxppc64le")
313310
}

cmd/dlv/dlv_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1467,9 +1467,6 @@ func TestCapsLock(t *testing.T) {
14671467
if goos == "linux" && goarch == "ppc64le" {
14681468
args = append([]string{"-buildtags", "exp.linuxppc64le"}, args...)
14691469
}
1470-
if goos == "windows" && goarch == "arm64" {
1471-
args = append([]string{"-buildtags", "exp.winarm64"}, args...)
1472-
}
14731470

14741471
cmd := exec.Command("capslock", args...)
14751472
cmd.Dir = protest.ProjectRoot()

pkg/proc/native/support_sentinel_windows.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//go:build windows && !amd64 && !(arm64 && exp.winarm64)
1+
//go:build windows && !amd64 && !arm64
22

33
// This file is used to detect build on unsupported GOOS/GOARCH combinations.
44

pkg/proc/test/support.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -450,9 +450,6 @@ func GetDlvBinary(t *testing.T) string {
450450
t.Helper()
451451

452452
var tags []string
453-
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
454-
tags = []string{"-tags=exp.winarm64"}
455-
}
456453
if runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le" {
457454
tags = []string{"-tags=exp.linuxppc64le"}
458455
}

service/test/integration2_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3213,10 +3213,6 @@ func TestGuessSubstitutePath(t *testing.T) {
32133213
t.Setenv("GOFLAGS", "-tags=exp.linuxriscv64")
32143214
case "loong64":
32153215
t.Setenv("GOFLAGS", "-tags=exp.linuxloong64")
3216-
case "arm64":
3217-
if runtime.GOOS == "windows" {
3218-
t.Setenv("GOFLAGS", "-tags=exp.winarm64")
3219-
}
32203216
}
32213217

32223218
gsp, err := client.GuessSubstitutePath()

0 commit comments

Comments
 (0)