pkg/proc: guard register logging from nil pointer dereferences (#4188)

aarzilli · web-flow · commit f147ac3f28e7 · 2025-10-28T11:59:57.000-04:00
If we can't read a thread's registers don't try to print them. Fixes #4187
diff --git a/pkg/proc/target_exec.go b/pkg/proc/target_exec.go
@@ -168,7 +168,11 @@ func (grp *TargetGroup) Continue() error {
 				log.Debugf("callInjection protocol on:")
 				for _, th := range threads {
 					regs, _ := th.Registers()
-					log.Debugf("\t%d PC=%#x", th.ThreadID(), regs.PC())
+					if regs != nil {
+						log.Debugf("\t%d PC=%#x", th.ThreadID(), regs.PC())
+					} else {
+						log.Debugf("\t%d (no registers)", th.ThreadID())
+					}
 				}
 			}
 			callInjectionDoneThis, callErrThis := callInjectionProtocol(dbp, trapthread, threads)

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,11 @@ func (grp *TargetGroup) Continue() error {`
`168`	`168`	`log.Debugf("callInjection protocol on:")`
`169`	`169`	`for _, th := range threads {`
`170`	`170`	`regs, _ := th.Registers()`
`171`		`- log.Debugf("\t%d PC=%#x", th.ThreadID(), regs.PC())`
	`171`	`+ if regs != nil {`
	`172`	`+ log.Debugf("\t%d PC=%#x", th.ThreadID(), regs.PC())`
	`173`	`+ } else {`
	`174`	`+ log.Debugf("\t%d (no registers)", th.ThreadID())`
	`175`	`+ }`
`172`	`176`	`}`
`173`	`177`	`}`
`174`	`178`	`callInjectionDoneThis, callErrThis := callInjectionProtocol(dbp, trapthread, threads)`