add comments

Author: pchampio

video_player/README.md

@@ -16,18 +16,18 @@ Then add the following option to your go-flutter [application options](https://g
 flutter.AddPlugin(&video_player.VideoPlayerPlugin{}),
 ```
 
-The plugin uses a third party library to handle video to image decoding.  
-The video decoding is done by [3d0c/gmf](https://github.com/3d0c/gmf), a go
+The plugin uses a third party library to handle video to image decoding,
+ [3d0c/gmf](https://github.com/3d0c/gmf), a go
 FFmpeg bindings.  
-If you have trubble installing the plugin, checkout their [installation](https://github.com/3d0c/gmf#installation) procedure.
+If you have trouble installing the plugin, checkout their [installation](https://github.com/3d0c/gmf#installation) procedure.
 
 ## :warning: Disclaimer :warning:
 
 This plugin is available for educational purposes, and the go-flutter team isn't
 actively working on it.  
 **`Don't use it in production`** nasty bugs can occur
 (mostly memory leak).  
-We are looking for maintainers. Pull Requests are most welcome!
+The plugin needs a significant rewrite. We are looking for maintainers. Pull Requests are most welcome!
 
 ## Issues
 

video_player/ffmpeg-video.go

@@ -3,9 +3,7 @@ package video_player
 // This file hides the ffmpeg related computations.
 //
 // The api exposed by github.com/3d0c/gmf is messy (all go-ffmpeg lib are)
-// which explain the following mess.
-//
-// Be very careful when you make changes to this file.
+// which explain some of the following mess :).
 //
 // Based on the examples 'video-to-goImage.go' of 3d0c/gmf.
 // TODO: fix the memory leak will occur..
@@ -19,9 +17,6 @@ import (
 	"github.com/3d0c/gmf"
 )
 
-// #include "libavformat/avformat.h"
-import "C"
-
 type ffmpegVideo struct {
 	swsctx         *gmf.SwsCtx
 	ist            *gmf.Stream

video_player/go.mod

@@ -4,5 +4,5 @@ go 1.12
 
 require (
 	github.com/3d0c/gmf v0.0.0-20190724130615-f4b5acb7db5c
-	github.com/go-flutter-desktop/go-flutter v0.27.4-0.20190804194945-75d1c8142b5d
+	github.com/go-flutter-desktop/go-flutter v0.29.0
 )

video_player/go.sum

@@ -3,8 +3,8 @@ github.com/3d0c/gmf v0.0.0-20190724130615-f4b5acb7db5c/go.mod h1:0QMRcUq2JsDECeA
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/go-flutter-desktop/go-flutter v0.27.4-0.20190804194945-75d1c8142b5d h1:hAF4o4UQzPlDCrP1pxSrFdJJEg82Dn1K4SaESYv+5KU=
-github.com/go-flutter-desktop/go-flutter v0.27.4-0.20190804194945-75d1c8142b5d/go.mod h1:j9eXkEzV8ku7a3Ve4s8cYKPiOkMIAg549S8K9VomyY4=
+github.com/go-flutter-desktop/go-flutter v0.29.0 h1:PONS1I6HN64tsBViWSnI/DMUCs2Oth37Gg1eDkGri0g=
+github.com/go-flutter-desktop/go-flutter v0.29.0/go.mod h1:jOq/jZc4gZCibc661M7R5nDVc9/mv2dDMpWsyNaVuGY=
 github.com/go-gl/gl v0.0.0-20190320180904-bf2b1f2f34d7 h1:SCYMcCJ89LjRGwEa0tRluNRiMjZHalQZrVrvTbPh+qw=
 github.com/go-gl/gl v0.0.0-20190320180904-bf2b1f2f34d7/go.mod h1:482civXOzJJCPzJ4ZOX/pwvXBWSnzD4OKMdH4ClKGbk=
 github.com/go-gl/glfw v0.0.0-20190519095719-e6da0acd62b1 h1:noz9OnjV5PMOZWNOI+y1cS5rnxuJfpY6leIgQEEdBQw=
@@ -14,5 +14,9 @@ github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINE
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
-github.com/stretchr/testify v1.3.0 h1:TivCn/peBQ7UY8ooIcPgZFpTNSz0Q2U6UrFlUfqbe0Q=
-github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
+github.com/stretchr/testify v1.4.0 h1:2E4SXV/wtOkTonXsotYi4li6zVWxYlZuYNCXe9XRJyk=
+github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
+gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
+gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
+gopkg.in/yaml.v2 v2.2.2 h1:ZCJp+EgiOT7lHqUV2J862kp8Qj64Jo6az82+3Td9dZw=
+gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=