Follow yp05327's suggestion

Author: lunny

models/issues/issue.go

@@ -197,10 +197,10 @@ func (issue *Issue) LoadAttachments(ctx context.Context) (err error) {
 	}
 
 	issue.Attachments, err = repo_model.GetAttachmentsByIssueID(ctx, issue.ID)
-	issue.isAttachmentsLoaded = true
 	if err != nil {
 		return fmt.Errorf("getAttachmentsByIssueID [%d]: %w", issue.ID, err)
 	}
+	issue.isAttachmentsLoaded = true
 	return nil
 }
 
@@ -306,10 +306,10 @@ func (issue *Issue) loadReactions(ctx context.Context) (err error) {
 func (issue *Issue) LoadMilestone(ctx context.Context) (err error) {
 	if !issue.isMilestoneLoaded && (issue.Milestone == nil || issue.Milestone.ID != issue.MilestoneID) && issue.MilestoneID > 0 {
 		issue.Milestone, err = GetMilestoneByRepoID(ctx, issue.RepoID, issue.MilestoneID)
-		issue.isMilestoneLoaded = true
 		if err != nil && !IsErrMilestoneNotExist(err) {
 			return fmt.Errorf("getMilestoneByRepoID [repo_id: %d, milestone_id: %d]: %w", issue.RepoID, issue.MilestoneID, err)
 		}
+		issue.isMilestoneLoaded = true
 	}
 	return nil
 }

models/issues/issue_label.go

@@ -330,10 +330,10 @@ func FixIssueLabelWithOutsideLabels(ctx context.Context) (int64, error) {
 func (issue *Issue) LoadLabels(ctx context.Context) (err error) {
 	if !issue.isLabelsLoaded && issue.Labels == nil && issue.ID != 0 {
 		issue.Labels, err = GetLabelsByIssueID(ctx, issue.ID)
-		issue.isLabelsLoaded = true
 		if err != nil {
 			return fmt.Errorf("getLabelsByIssueID [%d]: %w", issue.ID, err)
 		}
+		issue.isLabelsLoaded = true
 	}
 	return nil
 }

models/issues/pull.go

@@ -294,15 +294,14 @@ func (pr *PullRequest) LoadRequestedReviewers(ctx context.Context) error {
 		return nil
 	}
 
-	pr.isRequestedReviewersLoaded = true
 	reviews, err := GetReviewsByIssueID(ctx, pr.Issue.ID)
 	if err != nil {
 		return err
 	}
-
 	if err = reviews.LoadReviewers(ctx); err != nil {
 		return err
 	}
+	pr.isRequestedReviewersLoaded = true
 	for _, review := range reviews {
 		pr.RequestedReviewers = append(pr.RequestedReviewers, review.Reviewer)
 	}