Skip to content

Commit 39378ee

Browse files
committed
fine tune for "clone" panel
1 parent 5d60d68 commit 39378ee

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

web_src/css/repo.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -1334,7 +1334,7 @@ td .commit-summary {
13341334

13351335
.repository .repository-summary .sub-menu .item {
13361336
flex: 1;
1337-
height: 33.6px; /* match search bar height, need to be improved in the future to use some consistent methods */
1337+
height: 33px; /* match search bar height, need to be improved in the future to use some consistent methods */
13381338
line-height: var(--line-height-default);
13391339
display: flex;
13401340
align-items: center;

web_src/css/repo/home-file-list.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
grid-template-columns: auto 1fr auto;
55
border: 1px solid var(--color-light-border);
66
border-radius: var(--border-radius);
7-
margin: 8px 0;
7+
margin: 10px 0; /* match the "clone-panel-popup" margin to avoid "visual double-border" */
88
}
99

1010
#repo-files-table .svg.octicon-file-directory-fill,

web_src/js/features/repo-common.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,15 @@ function initCloneSchemeUrlSelection(parent: Element) {
9292

9393
function initClonePanelButton(btn: HTMLButtonElement) {
9494
const elPanel = btn.nextElementSibling;
95+
// "init" must be before the "createTippy" otherwise the "tippy-target" will be removed from the document
96+
initCloneSchemeUrlSelection(elPanel);
9597
createTippy(btn, {
9698
content: elPanel,
9799
trigger: 'click',
98100
placement: 'bottom-end',
99101
interactive: true,
100102
hideOnClick: true,
101103
});
102-
initCloneSchemeUrlSelection(elPanel);
103104
}
104105

105106
export function initRepoCloneButtons() {

0 commit comments

Comments
 (0)