Skip to content

Commit 3a51c37

Browse files
authored
Check if the due_date is nil when editing issues (#32035)
1 parent f05d9c9 commit 3a51c37

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

Diff for: routers/api/v1/repo/issue.go

+10-4
Original file line numberDiff line numberDiff line change
@@ -833,10 +833,16 @@ func EditIssue(ctx *context.APIContext) {
833833
if (form.Deadline != nil || form.RemoveDeadline != nil) && canWrite {
834834
var deadlineUnix timeutil.TimeStamp
835835

836-
if (form.RemoveDeadline == nil || !*form.RemoveDeadline) && !form.Deadline.IsZero() {
837-
deadline := time.Date(form.Deadline.Year(), form.Deadline.Month(), form.Deadline.Day(),
838-
23, 59, 59, 0, form.Deadline.Location())
839-
deadlineUnix = timeutil.TimeStamp(deadline.Unix())
836+
if form.RemoveDeadline == nil || !*form.RemoveDeadline {
837+
if form.Deadline == nil {
838+
ctx.Error(http.StatusBadRequest, "", "The due_date cannot be empty")
839+
return
840+
}
841+
if !form.Deadline.IsZero() {
842+
deadline := time.Date(form.Deadline.Year(), form.Deadline.Month(), form.Deadline.Day(),
843+
23, 59, 59, 0, form.Deadline.Location())
844+
deadlineUnix = timeutil.TimeStamp(deadline.Unix())
845+
}
840846
}
841847

842848
if err := issues_model.UpdateIssueDeadline(ctx, issue, deadlineUnix, ctx.Doer); err != nil {

0 commit comments

Comments
 (0)