Support legacy _links LFS batch responses

Signed-off-by: Royce Remer <[email protected]>

Author: rremer

Diff for: modules/lfs/http_client.go

@@ -179,8 +179,17 @@ func (c *HTTPClient) performOperation(ctx context.Context, objects []Pointer, dc
 				}
 			}
 		} else {
+			var link *Link
 			link, ok := object.Actions["download"]
 			if !ok {
+				// no actions block in response, try legacy response schema
+				link, ok = object.Links["download"]
+				if ok {
+					log.Info("%+v is using a deprecated batch schema response!", object)
+				}
+			}
+			if !ok {
+				// do download action in modern or legacy schemas
 				log.Debug("%+v", object)
 				return errors.New("missing action 'download'")
 			}

Diff for: modules/lfs/http_client_test.go

@@ -59,6 +59,17 @@ func lfsTestRoundtripHandler(req *http.Request) *http.Response {
 				},
 			},
 		}
+	} else if strings.Contains(url, "legacy-batch-request-download") {
+		batchResponse = &BatchResponse{
+			Transfer: "dummy",
+			Objects: []*ObjectResponse{
+				{
+					Links: map[string]*Link{
+						"download": {},
+					},
+				},
+			},
+		}
 	} else if strings.Contains(url, "valid-batch-request-upload") {
 		batchResponse = &BatchResponse{
 			Transfer: "dummy",
@@ -229,6 +240,11 @@ func TestHTTPClientDownload(t *testing.T) {
 			endpoint:      "https://unknown-actions-map.io",
 			expectederror: "missing action 'download'",
 		},
+		// case 11
+		{
+			endpoint:      "https://legacy-batch-request-download.io",
+			expectederror: "",
+		},
 	}
 
 	for n, c := range cases {

Diff for: modules/lfs/shared.go

@@ -47,6 +47,7 @@ type BatchResponse struct {
 type ObjectResponse struct {
 	Pointer
 	Actions map[string]*Link `json:"actions,omitempty"`
+	Links   map[string]*Link `json:"_links,omitempty"`
 	Error   *ObjectError     `json:"error,omitempty"`
 }