Skip to content

Commit 695f5d1

Browse files
wxiaoguangGiteaBot
andauthored
Fix incorrect link-action event target (#25306)
A regression of #25210 The `e.target` is not "this", eg: `<button link-action><svg></button>`, then `this` should be `button` but `e.target` is `svg`. I will propose a clearer and complete solution for these "link-action" "show-modal" elements after #24724 Co-authored-by: Giteabot <[email protected]>
1 parent 1ea6b8f commit 695f5d1

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

web_src/js/features/common-global.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,10 @@ function linkAction(e) {
268268
e.preventDefault();
269269

270270
// A "link-action" can post AJAX request to its "data-url"
271-
// Then the browser is redirect to: the "redirect" in response, or "data-redirect" attribute, or current URL by reloading.
272-
// If the "link-action" has "data-modal-confirm(-html)" attribute, a confirm modal dialog will be shown before taking action.
271+
// Then the browser is redirected to: the "redirect" in response, or "data-redirect" attribute, or current URL by reloading.
272+
// If the "link-action" has "data-modal-confirm" attribute, a confirm modal dialog will be shown before taking action.
273273

274-
const $this = $(e.target);
274+
const $this = $(this);
275275
const redirect = $this.attr('data-redirect');
276276

277277
const doRequest = () => {

0 commit comments

Comments
 (0)