Skip to content

Commit adea500

Browse files
authored
Resolve duplicate local string key related to PR comments (#32073)
A regression in #31924 caused there to be two `issues.review.comment` keys in the English language locale file, leading to a problem when reading PR review histories that contain comments. This snapshot addresses this by making the newer key unique.
1 parent 1fede04 commit adea500

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Diff for: models/issues/review.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ func (r *Review) TooltipContent() string {
247247
}
248248
return "repo.issues.review.official"
249249
case ReviewTypeComment:
250-
return "repo.issues.review.comment"
250+
return "repo.issues.review.commented"
251251
case ReviewTypeReject:
252252
return "repo.issues.review.rejected"
253253
case ReviewTypeRequest:

Diff for: options/locale/locale_en-US.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -1757,7 +1757,7 @@ issues.review.hide_resolved = Hide resolved
17571757
issues.review.resolve_conversation = Resolve conversation
17581758
issues.review.un_resolve_conversation = Unresolve conversation
17591759
issues.review.resolved_by = marked this conversation as resolved
1760-
issues.review.comment = Comment
1760+
issues.review.commented = Comment
17611761
issues.review.official = Approved
17621762
issues.review.requested = Review pending
17631763
issues.review.rejected = Changes requested

0 commit comments

Comments
 (0)