Return 404 instead of error when commit not exist (#31977)

AdamMajer · web-flow · commit bf7ae0429cdf · 2024-09-06T02:39:23.000+08:00
Fix #31976
diff --git a/routers/api/v1/repo/commits.go b/routers/api/v1/repo/commits.go
@@ -195,7 +195,7 @@ func GetAllCommits(ctx *context.APIContext) {
 			// get commit specified by sha
 			baseCommit, err = ctx.Repo.GitRepo.GetCommit(sha)
 			if err != nil {
-				ctx.Error(http.StatusInternalServerError, "GetCommit", err)
+				ctx.NotFoundOrServerError("GetCommit", git.IsErrNotExist, err)
 				return
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ func GetAllCommits(ctx *context.APIContext) {`
`195`	`195`	`// get commit specified by sha`
`196`	`196`	`baseCommit, err = ctx.Repo.GitRepo.GetCommit(sha)`
`197`	`197`	`if err != nil {`
`198`		`- ctx.Error(http.StatusInternalServerError, "GetCommit", err)`
	`198`	`+ ctx.NotFoundOrServerError("GetCommit", git.IsErrNotExist, err)`
`199`	`199`	`return`
`200`	`200`	`}`
`201`	`201`	`}`