Skip to content

Commit dbc112d

Browse files
committed
add context to GetTree
1 parent 68a9306 commit dbc112d

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

modules/git/repo_tree_gogit.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
package git
88

99
import (
10+
"context"
1011
"errors"
1112

1213
"github.com/go-git/go-git/v5/plumbing"
@@ -29,14 +30,14 @@ func (repo *Repository) getTree(id ObjectID) (*Tree, error) {
2930
}
3031

3132
// GetTree find the tree object in the repository.
32-
func (repo *Repository) GetTree(idStr string) (*Tree, error) {
33+
func (repo *Repository) GetTree(ctx context.Context, idStr string) (*Tree, error) {
3334
objectFormat, err := repo.GetObjectFormat()
3435
if err != nil {
3536
return nil, err
3637
}
3738

3839
if len(idStr) != objectFormat.FullLength() {
39-
res, _, err := NewCommand("rev-parse", "--verify").AddDynamicArguments(idStr).RunStdString(repo.Ctx, &RunOpts{Dir: repo.Path})
40+
res, _, err := NewCommand("rev-parse", "--verify").AddDynamicArguments(idStr).RunStdString(ctx, &RunOpts{Dir: repo.Path})
4041
if err != nil {
4142
return nil, err
4243
}

modules/git/repo_tree_nogogit.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
package git
77

88
import (
9+
"context"
910
"io"
1011
)
1112

@@ -75,7 +76,7 @@ func (repo *Repository) getTree(id ObjectID) (*Tree, error) {
7576
}
7677

7778
// GetTree find the tree object in the repository.
78-
func (repo *Repository) GetTree(idStr string) (*Tree, error) {
79+
func (repo *Repository) GetTree(_ context.Context,idStr string) (*Tree, error) {
7980
objectFormat, err := repo.GetObjectFormat()
8081
if err != nil {
8182
return nil, err

services/pull/patch.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ func checkConflicts(ctx context.Context, pr *issues_model.PullRequest, gitRepo *
330330
return false, fmt.Errorf("unable to write unconflicted tree: %w\n`git ls-files -u`:\n%s", err, lsfiles)
331331
}
332332
treeHash = strings.TrimSpace(treeHash)
333-
baseTree, err := gitRepo.GetTree("base")
333+
baseTree, err := gitRepo.GetTree(ctx, "base")
334334
if err != nil {
335335
return false, err
336336
}

services/repository/files/tree.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func (err ErrSHANotFound) Unwrap() error {
3636

3737
// GetTreeBySHA get the GitTreeResponse of a repository using a sha hash.
3838
func GetTreeBySHA(ctx context.Context, repo *repo_model.Repository, gitRepo *git.Repository, sha string, page, perPage int, recursive bool) (*api.GitTreeResponse, error) {
39-
gitTree, err := gitRepo.GetTree(sha)
39+
gitTree, err := gitRepo.GetTree(ctx, sha)
4040
if err != nil || gitTree == nil {
4141
return nil, ErrSHANotFound{ // TODO: this error has never been catch outside of this function
4242
SHA: sha,

services/wiki/wiki_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ func TestRepository_AddWikiPage(t *testing.T) {
170170
require.NoError(t, err)
171171

172172
defer gitRepo.Close()
173-
masterTree, err := gitRepo.GetTree(repo.DefaultWikiBranch)
173+
masterTree, err := gitRepo.GetTree(t.Context(), repo.DefaultWikiBranch)
174174
assert.NoError(t, err)
175175
gitPath := WebPathToGitPath(webPath)
176176
entry, err := masterTree.GetTreeEntryByPath(gitPath)
@@ -215,7 +215,7 @@ func TestRepository_EditWikiPage(t *testing.T) {
215215
// Now need to show that the page has been added:
216216
gitRepo, err := gitrepo.OpenWikiRepository(git.DefaultContext, repo)
217217
assert.NoError(t, err)
218-
masterTree, err := gitRepo.GetTree(repo.DefaultWikiBranch)
218+
masterTree, err := gitRepo.GetTree(t.Context(), repo.DefaultWikiBranch)
219219
assert.NoError(t, err)
220220
gitPath := WebPathToGitPath(webPath)
221221
entry, err := masterTree.GetTreeEntryByPath(gitPath)
@@ -241,7 +241,7 @@ func TestRepository_DeleteWikiPage(t *testing.T) {
241241
require.NoError(t, err)
242242

243243
defer gitRepo.Close()
244-
masterTree, err := gitRepo.GetTree(repo.DefaultWikiBranch)
244+
masterTree, err := gitRepo.GetTree(t.Context(), repo.DefaultWikiBranch)
245245
assert.NoError(t, err)
246246
gitPath := WebPathToGitPath("Home")
247247
_, err = masterTree.GetTreeEntryByPath(gitPath)

0 commit comments

Comments
 (0)