Skip to content

Incorrect job status agreggations #32857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheFox0x7 opened this issue Dec 15, 2024 · 2 comments · Fixed by #32859
Closed

Incorrect job status agreggations #32857

TheFox0x7 opened this issue Dec 15, 2024 · 2 comments · Fixed by #32859
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Milestone

Comments

@TheFox0x7
Copy link
Contributor

Description

I believe AggregateJobStatus works incorrectly. First found and reported in fork.

Currently aggregation can return one of 4 states for a job:

  • Failure if all jobs are done and one is a fail
  • Success if all jobs are done and none failed
  • Waiting if none are running or done
  • Finally running if none of the above apply

It ignores cancellations, blocks and skips completely despite those being states which might represent the run best - such as skip as an aggregate result when all jobs are completed and were skipped.

Rough reproducer is at: https://demo.gitea.com/TheFox0x7/bad-aggregation/actions and the github version https://github.com/TheFox0x7/repro.

Gitea Version

9264811

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

I used demo site to demonstrate the issue.

Database

None

@lunny lunny added the topic/gitea-actions related to the actions of Gitea label Dec 15, 2024
@wxiaoguang
Copy link
Contributor

I can see there are at least 2 problems here:

  1. backend doesn't return "cancelled" status (AggregateJobStatus)
  2. frontend doesn't support rendering "cancelled" icon & status (templates/repo/actions/status.tmpl, web_src/js/components/ActionRunStatus.vue)

@wxiaoguang
Copy link
Contributor

Maybe this could work better: Fix incomplete Actions status aggregations #32859

@lunny lunny added this to the 1.23.0 milestone Dec 16, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants