Skip to content

acme crash in 1.23 preventing start of gitea #33177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bvgastel opened this issue Jan 9, 2025 · 3 comments · Fixed by #33178
Closed

acme crash in 1.23 preventing start of gitea #33177

bvgastel opened this issue Jan 9, 2025 · 3 comments · Fixed by #33178
Labels
type/bug
Milestone
1.23.1

Comments

@bvgastel
Copy link

bvgastel commented Jan 9, 2025

Description

Using gitea/gitea:latest docker image that was updated 11-12 hours ago to version 1.23. Since then start failure, see crash report.

2025/01/09 13:36:13 cmd/web.go:315:listen() [I] Listen: https://0.0.0.0:443
2025/01/09 13:36:13 cmd/web.go:319:listen() [I] AppURL(ROOT_URL): https://gitea.bitpowder.com/
2025/01/09 13:36:13 cmd/web.go:322:listen() [I] LFS server enabled
2025/01/09 13:36:13 cmd/web.go:242:func1() [F] PANIC: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:262 (0x47bb78)
/usr/local/go/src/runtime/signal_unix.go:917 (0x47bb48)
/go/pkg/mod/github.com/caddyserver/[email protected]/cache.go:335 (0x2d534ed)
/go/pkg/mod/github.com/caddyserver/[email protected]/config.go:398 (0x2d59bc4)
/go/pkg/mod/github.com/caddyserver/[email protected]/config.go:387 (0x2d59af1)
/go/pkg/mod/github.com/caddyserver/[email protected]/config.go:322 (0x2dab259)
/go/src/code.gitea.io/gitea/cmd/web_acme.go:83 (0x2dab205)
/go/src/code.gitea.io/gitea/cmd/web.go:334 (0x2daaa34)
/go/src/code.gitea.io/gitea/cmd/web.go:223 (0x2da9b84)
/go/src/code.gitea.io/gitea/cmd/web.go:273 (0x2daa08b)
/go/src/code.gitea.io/gitea/cmd/main.go:111 (0x2da0242)
/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:276 (0x1f6cca1)
/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:269 (0x1f6cf24)
/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:333 (0x1f69704)
/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:307 (0x2da0d38)
/go/src/code.gitea.io/gitea/cmd/main.go:172 (0x2da0d1c)
/go/src/code.gitea.io/gitea/main.go:46 (0x2de6bb8)
/usr/local/go/src/runtime/proc.go:272 (0x442fca)
/usr/local/go/src/runtime/asm_amd64.s:1700 (0x482100)
Received signal 15; terminating.

Did a rollback to 1.22 for now.

Gitea Version

1.23.0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker/ACME.

Database

SQLite
@wxiaoguang wxiaoguang mentioned this issue Jan 9, 2025
Merged
@wxiaoguang
Copy link
Contributor

Sorry for the inconvenience: Fix ACME panic #33178

@bvgastel
Copy link
Author

bvgastel commented Jan 9, 2025

These things happen. Thanks for the quick response. Hope it can be released in a few days.

@lunny lunny added this to the 1.23.1 milestone Jan 9, 2025
@lunny lunny closed this as completed in 5b31077 Jan 9, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jan 9, 2025
@wxiaoguang @GiteaBot
Fix ACME panic (go-gitea#33178)
626cb12 
Fix go-gitea#33177, Manually tested:

````
1.7364311850484018e+09	info	maintenance	started background certificate maintenance	{"cache": "0x1400ca64180"}
1.736431185054049e+09	info	obtain	acquiring lock	{"identifier": "example.com"}
1.736431185058073e+09	info	obtain	lock acquired	{"identifier": "example.com"}
1.736431185058133e+09	info	obtain	obtaining certificate	{"identifier": "example.com"}
````
@GiteaBot GiteaBot mentioned this issue Jan 9, 2025
Merged
lunny pushed a commit that referenced this issue Jan 10, 2025
@GiteaBot @wxiaoguang
Fix ACME panic (#33178) (#33186)
ed1828c 
Backport #33178 by @wxiaoguang

Fix #33177, Manually tested:

````
1.7364311850484018e+09	info	maintenance	started background certificate maintenance	{"cache": "0x1400ca64180"}
1.736431185054049e+09	info	obtain	acquiring lock	{"identifier": "example.com"}
1.736431185058073e+09	info	obtain	lock acquired	{"identifier": "example.com"}
1.736431185058133e+09	info	obtain	obtaining certificate	{"identifier": "example.com"}
````

Co-authored-by: wxiaoguang <[email protected]>
@wxiaoguang
Copy link
Contributor

1.23 nightly (will be 1.23.1 soon) is ready, it also contains some other fixes to have.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.23.1
Development

Successfully merging a pull request may close this issue.

Fix ACME panic wxiaoguang/gitea
3 participants
@lunny @bvgastel @wxiaoguang