Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark the containing directory as viewed in the file tree when all its files are viewed #25644

Open
delvh opened this issue Jul 3, 2023 · 0 comments · May be fixed by #33958
Open

Mark the containing directory as viewed in the file tree when all its files are viewed #25644

delvh opened this issue Jul 3, 2023 · 0 comments · May be fixed by #33958
Labels
topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.24.0

Comments

@delvh
Copy link
Member

delvh commented Jul 3, 2023

Feature Description

At the moment, Gitea highlights viewed files differently in the filetree (see screenshot 1, implemented by #24956).
However, I've noticed that the directories grab unnecessary attention when skimming through the tree to see what is reviewed and what isn't.
So, what I'm proposing to do when a file is marked as viewed:

  • do what is currently done
  • check for the parent if all its children have been marked as viewed
  • if that's the case, mark this parent as viewed and continue with the parent of this directory

When a file is de-marked, we need to de-mark its parents as well.
It is some overhead compared to now, but I think it's worth it to allow faster skimming through the tree.

Screenshots

Current appearance

image

Expected appearance

image
@delvh delvh added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Jul 3, 2023
kerwin612 added a commit to kerwin612/gitea that referenced this issue Mar 21, 2025
@kerwin612
Mark parent directory as viewed when all files are viewed (fixes go-g…
facb60b 
…itea#25644)
@lunny lunny linked a pull request Mar 21, 2025 that will close this issue
Open
@lunny lunny added this to the 1.24.0 milestone Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

Mark parent directory as viewed when all files are viewed kerwin612/gitea
2 participants
@lunny @delvh