Skip to content

Unify save buttons on Repo Settings Screen #38807

Description

@smileBeda

What problem would this solve?

I am referring to repo > settings. There currently are:

  • one save for the basic settings first section
  • even if inside the same "card" of basic settings, another button for the profile pic of the repo
  • mirror settings save button
  • advanced settings save button
  • signing verification save button
  • admin settings save button

The main gripe I have with this is, the sections span taller than a main screen, as such, you do some changes, fast-scroll down and often overshoot the save button of that section and land on one even further down without realising it, save, and lose your settings of the card you where supposed to save

What do you propose?

A unified button that saves all sections at once would be probably the simplest fix with highest effect.

On the fly save would be more neat, but more complex, prone to issues, increase attack surface, so probably less the desired approach.

See also discussion here and onwards:
https://discord.com/channels/322538954119184384/322538954119184384/1534973271311651017

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/proposalThe new feature has not been accepted yet but needs to be discussed first.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions