proposal: please consider another lib than https://github.com/spf13/cast

[ccoVeille]

You have a proposal, explain it!

This lib is still maintained but the way it converts integer is very strange

https://github.com/spf13/cast

Describe the solution you'd like

a conversion of -1 | toUint should lead to error

Additional context

Please take a look at https://github.com/ccoVeille/go-safecast

I'm not suggesting to use my lib, but you might see some other examples.

Of course, I would be honored if you consider my lib

Code of Conduct

• I agree to follow this project's Code of Conduct

[42atomys]

Hello, thanks to have opening an issue.

I have try with v1.0.0-rc.2 and the template {{ toUint -1 }} result to the error defined here https://github.com/spf13/cast/blob/master/caste.go#L527 :

template: test:1:8: executing "test" at <toUint .V>: error calling toUint: unable to cast negative value

Can you check your code and give me the part impacted

[ccoVeille]

I reported the issue by reading the documentation

The problem I found was here

https://github.com/spf13/cast/blob/487df0093482b2ca1c00cb3b92e30899c37038a1/caste.go#L287

A uint can overflow int64

you can take 9223372036854775807 that is the max and add 1, so 9223372036854775808 using toInt or toInt64 on it, should cause errors, but it doesn't.

I reported by using the example of a negative number because it was simpler to explain, but I wrongly assumed negative number could cause a problem too.

But please note, I might be wrong again 🤕

[42atomys]

@ccoVeille Hi 👋 After some investigation, I believe it would be better to incorporate the casting directly into sprout itself to only have what we want and how we want it !