Fix etherscan tsconfig file

goat-sdk · Jan 15, 2025 · 83c3500 · 83c3500
1 parent fecf4d9
commit 83c3500
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 37 deletions.
diff --git a/typescript/packages/plugins/etherscan/src/etherscan.service.ts b/typescript/packages/plugins/etherscan/src/etherscan.service.ts
@@ -72,11 +72,11 @@ export class EtherscanService {
         return etherscanRequest(
             buildUrl(network, "account", "txlist", {
                 address,
-                startblock: startBlock,
-                endblock: endBlock,
-                page,
-                offset,
-                sort,
+                startblock: startBlock ?? "",
+                endblock: endBlock ?? "",
+                page: page ?? "",
+                offset: offset ?? "",
+                sort: sort ?? "",
             }),
             this.apiKey,
         );
@@ -243,8 +243,8 @@ export class EtherscanService {
         const { address, fromBlock, toBlock, topic0, topic1, topic2, topic3, network } = parameters;
         const params: Record<string, string | number> = {
             address,
-            fromBlock: typeof fromBlock === "number" ? `0x${fromBlock.toString(16)}` : fromBlock,
-            toBlock: typeof toBlock === "number" ? `0x${toBlock.toString(16)}` : toBlock,
+            fromBlock: typeof fromBlock === "number" ? `0x${fromBlock.toString(16)}` : (fromBlock ?? ""),
+            toBlock: typeof toBlock === "number" ? `0x${toBlock.toString(16)}` : (toBlock ?? ""),
         };
 
         if (topic0) params.topic0 = topic0;

diff --git a/typescript/packages/plugins/etherscan/tsconfig.json b/typescript/packages/plugins/etherscan/tsconfig.json
@@ -1,20 +1,6 @@
 {
-    "extends": "../../../tsconfig.json",
-    "compilerOptions": {
-        "target": "ES2020",
-        "module": "ESNext",
-        "moduleResolution": "node",
-        "experimentalDecorators": true,
-        "emitDecoratorMetadata": true,
-        "esModuleInterop": true,
-        "skipLibCheck": true,
-        "outDir": "./dist",
-        "rootDir": "./src"
-    },
+    "$schema": "https://json.schemastore.org/tsconfig",
+    "extends": "../../../tsconfig.base.json",
     "include": ["src/**/*"],
-    "references": [
-        {
-            "path": "../../core"
-        }
-    ]
+    "exclude": ["node_modules", "dist"]
 }
diff --git a/typescript/packages/plugins/etherscan/tsup.config.ts b/typescript/packages/plugins/etherscan/tsup.config.ts
@@ -1,17 +1,6 @@
 import { defineConfig } from "tsup";
+import { treeShakableConfig } from "../../../tsup.config.base";
 
 export default defineConfig({
-    entry: [
-        "src/index.ts",
-        "src/etherscan.plugin.ts",
-        "src/etherscan.service.ts",
-        "src/parameters.ts",
-        "src/request.ts",
-    ],
-    format: ["esm", "cjs"],
-    dts: true,
-    splitting: true,
-    sourcemap: true,
-    clean: true,
-    target: "es2022",
+    ...treeShakableConfig,
 });
diff --git a/typescript/packages/plugins/etherscan/turbo.json b/typescript/packages/plugins/etherscan/turbo.json
@@ -0,0 +1,11 @@
+{
+    "$schema": "https://turbo.build/schema.json",
+    "extends": ["//"],
+    "tasks": {
+        "build": {
+            "inputs": ["src/**", "tsup.config.ts", "!./**/*.test.{ts,tsx}", "tsconfig.json"],
+            "dependsOn": ["^build"],
+            "outputs": ["dist/**"]
+        }
+    }
+}