(NOBIDS) Add comment to ClearByPrefix

D13ce · D13ce · commit c0f41b75f678 · 2023-11-15T09:08:57.000+01:00
diff --git a/db/bigtable_common.go b/db/bigtable_common.go
@@ -132,6 +132,7 @@ func (bigtable *Bigtable) ClearByPrefix(table string, family, prefix string, dry
 			keysCount++
 		}
 
+		// we still need to commit in batches here (instead of just calling WriteBulk only once) as loading all keys to be deleted in memory first is not feasible as the delete function could be used to delete millions of rows
 		if mutsDelete.Len() == MAX_BATCH_MUTATIONS {
 			logrus.Infof("deleting %v keys (first key %v, last key %v)", len(mutsDelete.Keys), mutsDelete.Keys[0], mutsDelete.Keys[len(mutsDelete.Keys)-1])
 			if !dryRun {

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,7 @@ func (bigtable *Bigtable) ClearByPrefix(table string, family, prefix string, dry`
`132`	`132`	`keysCount++`
`133`	`133`	`}`
`134`	`134`
	`135`	`+ // we still need to commit in batches here (instead of just calling WriteBulk only once) as loading all keys to be deleted in memory first is not feasible as the delete function could be used to delete millions of rows`
`135`	`136`	`if mutsDelete.Len() == MAX_BATCH_MUTATIONS {`
`136`	`137`	`logrus.Infof("deleting %v keys (first key %v, last key %v)", len(mutsDelete.Keys), mutsDelete.Keys[0], mutsDelete.Keys[len(mutsDelete.Keys)-1])`
`137`	`138`	`if !dryRun {`