Constant string literals are considered Top pointers

[Robotechnic]

char * constDATA = "Hello, World!";

int invalidDereference() {
	constDATA[0] = 'h';
	return 0;
}

In this case, I should have at least a warning about the fact that I am writing in a constant string. However, I have the following:

Size of lval dereference expression constDATA + 0 is top. Out-of-bounds memory access may occur
Size of pointer constDATA in expression constDATA + 0 is top. Memory out-of-bounds access might occur

Regarding the fact that this string won't ever change, it is strange to have a top pointer.

[sim642]

Actually PR #1768 also added the case of + 0 for StrPtr, which was missing before, but that doesn't help here.
Because again, the memOutOfBounds analysis duplicates pointer arithmetic and doesn't benefit from that fix.

That analysis has some treatment of string pointers:

analyzer/src/analyses/memOutOfBounds.ml

Lines 257 to 258 in 9b9e214

	(* If the lval does not contain a pointer or if it does contain a pointer, but only points to string addresses, then no need to WARN *)
	if (not @@ lval_contains_a_ptr lval) || ptr_only_has_str_addr man (Lval lval) then ()

But it's also strange because it is possible to access a string constant out of bounds.