Merge branch 'master' into feature/signals

Change ConnectFlags from enum to bitfield.

Author: Bromeon

.github/workflows/full-ci.yml

@@ -104,6 +104,7 @@ jobs:
 
       # Note: could use `-- --no-deps` to not lint dependencies, however it doesn't really speed up and also skips deps in workspace.
       - name: "Check clippy"
+        # TODO(Rust 1.86): remove -A clippy::precedence; see https://github.com/godot-rust/gdext/pull/1055.
         run: |
           cargo clippy --all-targets $CLIPPY_FEATURES -- \
           -D clippy::suspicious \
@@ -113,7 +114,8 @@ jobs:
           -D clippy::dbg_macro \
           -D clippy::todo \
           -D clippy::unimplemented \
-          -D warnings
+          -D warnings \
+          -A clippy::precedence
 
   unit-test:
     name: unit-test (${{ matrix.name }}${{ matrix.rust-special }})

.github/workflows/minimal-ci.yml

@@ -96,6 +96,7 @@ jobs:
           components: clippy
 
       - name: "Check clippy"
+        # TODO(Rust 1.86): remove -A clippy::precedence; see https://github.com/godot-rust/gdext/pull/1055.
         run: |
           cargo clippy --all-targets $CLIPPY_FEATURES -- \
           -D clippy::suspicious \
@@ -105,7 +106,8 @@ jobs:
           -D clippy::dbg_macro \
           -D clippy::todo \
           -D clippy::unimplemented \
-          -D warnings
+          -D warnings \
+          -A clippy::precedence
           
 
   unit-test:

.github/workflows/release-version.yml

@@ -133,7 +133,8 @@ jobs:
           -D clippy::dbg_macro \
           -D clippy::todo \
           -D clippy::unimplemented \
-          -D warnings
+          -D warnings \
+          -A clippy::precedence
 
   rustfmt:
     runs-on: ubuntu-latest

Changelog.md

@@ -10,10 +10,50 @@ Cutting-edge API docs of the `master` branch are available [here](https://godot-
 
 ## Quick navigation
 
-- [v0.2.0](#v020), [v0.2.1](#v021), [v0.2.2](#v022), [v0.2.3](#v023)
+- [v0.2.0](#v020), [v0.2.1](#v021), [v0.2.2](#v022), [v0.2.3](#v023), [v0.2.4](#v024)
 - [v0.1.1](#v011), [v0.1.2](#v012), [v0.1.3](#v013)
 
 
+## [v0.2.4](https://docs.rs/godot/0.2.4)
+
+_24 February 2025_
+
+### 🌻 Features
+
+- Support additional doc comment markdown ([#1017](https://github.com/godot-rust/gdext/pull/1017))
+- Provide safe way for implementing `IScriptExtension::instance_has` ([#1013](https://github.com/godot-rust/gdext/pull/1013))
+- Global main thread ID ([#1045](https://github.com/godot-rust/gdext/pull/1045))
+- Add `validate_property` virtual func ([#1030](https://github.com/godot-rust/gdext/pull/1030))
+
+### 📈 Performance
+
+- Speed up creating and extending packed arrays from iterators up to 63× ([#1023](https://github.com/godot-rust/gdext/pull/1023))
+
+### 🧹 Quality of life
+
+- Test generation of proc-macro code via declarative macro ([#1008](https://github.com/godot-rust/gdext/pull/1008))
+- Test: support switching API versions in check.sh ([#1016](https://github.com/godot-rust/gdext/pull/1016))
+- Support `Variant::object_id()` for Godot <4.4; add `object_id_unchecked()` ([#1034](https://github.com/godot-rust/gdext/pull/1034))
+- Rename `Basis` + `Quaternion` methods, closer to Godot ([#1035](https://github.com/godot-rust/gdext/pull/1035))
+- Compare scripts via object_id ([#1036](https://github.com/godot-rust/gdext/pull/1036))
+- Add Godot 4.3 to minimal CI ([#1044](https://github.com/godot-rust/gdext/pull/1044))
+- Add .uid files for GDScript + GDExtension resources; update script cache ([#1050](https://github.com/godot-rust/gdext/pull/1050))
+- Add `#[allow(...)]` directives to macro-generated entries ([#1049](https://github.com/godot-rust/gdext/pull/1049))
+- Clippy: disable excessive operator-precedence lint ([#1055](https://github.com/godot-rust/gdext/pull/1055))
+
+### 🛠️ Bugfixes
+
+- Fix `Variant` -> `Gd` conversions not taking into account dead objects ([#1033](https://github.com/godot-rust/gdext/pull/1033))
+- Fix `DynGd<T,D>` export, implement proper export for `Array<DynGd<T,D>>` ([#1056](https://github.com/godot-rust/gdext/pull/1056))
+- In `#[var]s`, handle renamed `#[func]`s ([#1019](https://github.com/godot-rust/gdext/pull/1019))
+- 🌊 `#[signal]`: validate that there is no function body ([#1032](https://github.com/godot-rust/gdext/pull/1032))
+- Disambiguate virtual method calls ([#1020](https://github.com/godot-rust/gdext/pull/1020))
+- Parse doc strings with litrs ([#1015](https://github.com/godot-rust/gdext/pull/1015))
+- Register-docs: don't duplicate brief in description ([#1053](https://github.com/godot-rust/gdext/pull/1053))
+- Move some compile-time validations from godot to godot-ffi ([#1058](https://github.com/godot-rust/gdext/pull/1058))
+- Clippy: fix "looks like a formatting argument but it is not part of a formatting macro" ([#1041](https://github.com/godot-rust/gdext/pull/1041))
+
+
 ## [v0.2.3](https://docs.rs/godot/0.2.3)
 
 _30 January 2025_
@@ -149,6 +189,12 @@ See [devlog article](https://godot-rust.github.io/dev/november-2024-update) for
   - Vector conversion functions ([#824](https://github.com/godot-rust/gdext/pull/824))
   - Add Mul operator for Quaternion + Vector3 ([#894](https://github.com/godot-rust/gdext/pull/894))
 
+### 📈 Performance
+
+- `RawGd`: cache pointer to internal storage ([#831](https://github.com/godot-rust/gdext/pull/831))
+- `ClassName` now dynamic and faster ([#834](https://github.com/godot-rust/gdext/pull/834))
+- Pass-by-ref for non-`Copy` builtins (backend) ([#906](https://github.com/godot-rust/gdext/pull/906))
+
 ### 🧹 Quality of life
 
 - Renames and removals
@@ -214,12 +260,6 @@ See [devlog article](https://godot-rust.github.io/dev/november-2024-update) for
 - Math
   - `Vecor3::sign()` gives incorrect results due to `i32` conversion ([#865](https://github.com/godot-rust/gdext/pull/865))
 
-### 📈 Performance
-
-- `RawGd`: cache pointer to internal storage ([#831](https://github.com/godot-rust/gdext/pull/831))
-- `ClassName` now dynamic and faster ([#834](https://github.com/godot-rust/gdext/pull/834))
-- Pass-by-ref for non-`Copy` builtins (backend) ([#906](https://github.com/godot-rust/gdext/pull/906))
-
 ### 📚 Documentation
 
 - Builtin docs (impl blocks, navigation table, link to Godot) ([#821](https://github.com/godot-rust/gdext/pull/821))

check.sh

@@ -146,6 +146,12 @@ function cmd_fmt() {
 }
 
 function cmd_clippy() {
+    # TODO(Rust 1.86): remove `-A clippy::precedence`.
+    # In Rust 1.85, `clippy::precedence` includes bitmasking and shift operations. Rigid adherence to this rule results in more noisy code, with
+    # little benefits (being aware of bit operator precedence is something we can expect + bit manipulations are common in Godot).
+    # This behavior will be reverted in 1.86 and moved into new lint `precedence_bits` included in `restriction` category.
+    # See https://github.com/godot-rust/gdext/pull/1055 and https://github.com/rust-lang/rust-clippy/pull/14115.
+
     run cargo clippy --all-targets "${extraCargoArgs[@]}" -- \
         -D clippy::suspicious \
         -D clippy::style \
@@ -154,7 +160,8 @@ function cmd_clippy() {
         -D clippy::dbg_macro \
         -D clippy::todo \
         -D clippy::unimplemented \
-        -D warnings
+        -D warnings \
+        -A clippy::precedence
 }
 
 function cmd_klippy() {

godot-bindings/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "godot-bindings"
-version = "0.2.3"
+version = "0.2.4"
 edition = "2021"
 rust-version = "1.80"
 license = "MPL-2.0"

godot-cell/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "godot-cell"
-version = "0.2.3"
+version = "0.2.4"
 edition = "2021"
 rust-version = "1.80"
 license = "MPL-2.0"

godot-codegen/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "godot-codegen"
-version = "0.2.3"
+version = "0.2.4"
 edition = "2021"
 rust-version = "1.80"
 license = "MPL-2.0"
@@ -21,7 +21,7 @@ experimental-godot-api = []
 experimental-threads = []
 
 [dependencies]
-godot-bindings = { path = "../godot-bindings", version = "=0.2.3" }
+godot-bindings = { path = "../godot-bindings", version = "=0.2.4" }
 
 heck = "0.5"
 nanoserde = "0.1.35"
@@ -35,7 +35,7 @@ quote = "1.0.29"
 regex = { version = "1.5.5", default-features = false, features = ["std", "unicode-bool", "unicode-gencat"] }
 
 [build-dependencies]
-godot-bindings = { path = "../godot-bindings", version = "=0.2.3" } # emit_godot_version_cfg
+godot-bindings = { path = "../godot-bindings", version = "=0.2.4" } # emit_godot_version_cfg
 
 # https://docs.rs/about/metadata
 [package.metadata.docs.rs]

godot-codegen/src/models/domain_mapping.rs

@@ -559,7 +559,8 @@ impl UtilityFunction {
 impl Enum {
     pub fn from_json(json_enum: &JsonEnum, surrounding_class: Option<&TyName>) -> Self {
         let godot_name = &json_enum.name;
-        let is_bitfield = json_enum.is_bitfield;
+        let is_bitfield = special_cases::is_enum_bitfield(surrounding_class, godot_name)
+            .unwrap_or(json_enum.is_bitfield);
         let is_private = special_cases::is_enum_private(surrounding_class, godot_name);
         let is_exhaustive = special_cases::is_enum_exhaustive(surrounding_class, godot_name);
 

godot-codegen/src/special_cases/special_cases.rs

@@ -855,6 +855,21 @@ pub fn is_enum_exhaustive(class_name: Option<&TyName>, enum_name: &str) -> bool
     }
 }
 
+/// Overrides Godot's enum/bitfield status.
+/// * `Some(true)` -> bitfield
+/// * `Some(false)` -> enum
+/// * `None` -> keep default
+#[rustfmt::skip]
+pub fn is_enum_bitfield(class_name: Option<&TyName>, enum_name: &str) -> Option<bool> {
+    let class_name = class_name.map(|c| c.godot_ty.as_str());
+    match (class_name, enum_name) {
+        | (Some("Object"), "ConnectFlags")
+
+        => Some(true), 
+        _ => None
+    }
+}
+
 /// Whether an enum can be combined with another enum (return value) for bitmasking purposes.
 ///
 /// If multiple masks are ever necessary, this can be extended to return a slice instead of Option.