Skip to content

Commit 751451a

Browse files
bors[bot]chitoyuu
andauthored
Merge #1034
1034: Implement support for flexible self types r=chitoyuu a=chitoyuu `Instance` and `TInstance` can now be used as self types where applicable. Additionally, `Arc` is supported when `ArcData` is used as the user-data wrapper. The `self` type can be provided through the standard `arbitrary_self_types` syntax, or a `#[self]` attribute on the argument when unavailable. This is technically a breaking change because all `UserData` errors are now required to implement `std::error::Error`, although the possibility of actual breakage should be pretty low -- the wrapper types we ship should be powerful enough to cover most if not all valid use cases. Close #974 Co-authored-by: Chitose Yuuzaki <[email protected]>
2 parents 11466c8 + 726a5a5 commit 751451a

File tree

30 files changed

+363
-104
lines changed

30 files changed

+363
-104
lines changed

.github/workflows/full-ci.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ jobs:
130130
- rust: { toolchain: 'nightly' }
131131
testflags: '-- --skip ui_tests'
132132
- os: { id: ubuntu-latest, name: linux }
133-
rust: { toolchain: '1.63', postfix: ' (msrv 1.63)' }
133+
rust: { toolchain: '1.67', postfix: ' (msrv 1.67)' }
134134
testflags: '-- --skip ui_tests'
135135
- os: { id: ubuntu-latest, name: linux }
136136
rust: { toolchain: 'stable', postfix: ' (minimal-deps)', special: 'minimal-deps' }
@@ -298,16 +298,16 @@ jobs:
298298
godot: "3.5.1-stable"
299299
postfix: ' (nightly, inventory)'
300300
build_args: '--features inventory'
301-
- rust: '1.63'
301+
- rust: '1.67'
302302
godot: "3.5.1-stable"
303-
postfix: ' (msrv 1.63)'
304-
- rust: '1.63'
303+
postfix: ' (msrv 1.67)'
304+
- rust: '1.67'
305305
godot: "3.5.1-stable"
306-
postfix: ' (msrv 1.63, ptrcall)'
306+
postfix: ' (msrv 1.67, ptrcall)'
307307
build_args: '--features ptrcall'
308-
- rust: '1.63'
308+
- rust: '1.67'
309309
godot: "3.5.1-stable"
310-
postfix: ' (msrv 1.63, inventory)'
310+
postfix: ' (msrv 1.67, inventory)'
311311
build_args: '--features inventory'
312312

313313
# Test with oldest supported engine version

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
The bindings cover most of the exposed API of Godot 3.5, and are being used on a number of projects in development, but we still expect non-trivial breaking changes in the API in the coming releases. godot-rust adheres to [Cargo's semantic versioning](https://doc.rust-lang.org/cargo/reference/semver.html).
1919

20-
Minimum supported Rust version (MSRV) is **1.63**. We use the Rust 2021 Edition.
20+
Minimum supported Rust version (MSRV) is **1.67**. We use the Rust 2021 Edition.
2121

2222

2323
## Engine compatibility

bindings-generator/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ license = "MIT"
99
version = "0.11.3"
1010
workspace = ".."
1111
edition = "2021"
12-
rust-version = "1.63"
12+
rust-version = "1.67"
1313

1414
[features]
1515
debug = []

examples/builder-export/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name = "builder-export"
33
version = "0.1.0"
44
authors = ["The godot-rust developers"]
55
edition = "2021"
6-
rust-version = "1.63"
6+
rust-version = "1.67"
77
license = "MIT"
88
publish = false
99

examples/dodge-the-creeps/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ version = "0.1.0"
44
authors = ["The godot-rust developers"]
55
publish = false
66
edition = "2021"
7-
rust-version = "1.63"
7+
rust-version = "1.67"
88
license = "MIT"
99

1010
[lib]

examples/godot_tps_controller_port/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ version = "0.1.0"
44
edition = "2021"
55
authors = ["The godot-rust developers"]
66
publish = false
7-
rust-version = "1.63"
7+
rust-version = "1.67"
88
license = "MIT"
99

1010
[dependencies]

examples/hello-world/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ version = "0.1.0"
44
authors = ["The godot-rust developers"]
55
publish = false
66
edition = "2021"
7-
rust-version = "1.63"
7+
rust-version = "1.67"
88
license = "MIT"
99

1010
[lib]

examples/native-plugin/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name = "native-plugin"
33
version = "0.1.0"
44
authors = ["The godot-rust developers"]
55
edition = "2021"
6-
rust-version = "1.63"
6+
rust-version = "1.67"
77
license = "MIT"
88
publish = false
99

examples/property-export/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name = "property-export"
33
version = "0.1.0"
44
authors = ["The godot-rust developers"]
55
edition = "2021"
6-
rust-version = "1.63"
6+
rust-version = "1.67"
77
license = "MIT"
88
publish = false
99

examples/resource/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ version = "0.1.0"
44
authors = ["The godot-rust developers"]
55
publish = false
66
edition = "2021"
7-
rust-version = "1.63"
7+
rust-version = "1.67"
88
license = "MIT"
99

1010
[lib]

0 commit comments

Comments
 (0)