Use expose.tls.secret.secretName

[anthony-unicare]

The values file (values.yaml) defines expose.tls.secret.secretName as the name of the TLS secret for the ingress, but this is not used in templates/ingress/secret.yaml.

[MinerYang]

Hi @anthony-unicare ,

The values expose.tls.secret.secretName should be the name the secret already in-place before harbor installation. It would not be included in the ingress secret template file.

Any specific issue you encountered?

[anthony-unicare]

The values expose.tls.secret.secretName should be the name the secret already in-place before harbor installation. It would not be included in the ingress secret template file.

Any specific issue you encountered?

Hi @MinerYang,

Thank you for taking the time to respond.

Based on what you said about expose.tls.secret.secretName, there is arguably no problem. However, I expected it to also be used as the name of the secret that is created by the chart; that is, if it is set, then in templates/ingress/secret.yaml, on line 8, I think it should be used as the name of the secret. This gives the user of the chart control over the name of the secret.

[github-actions]

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.