Update tls1prf.go

qmuntal · dagood · web-flow · commit 27310671886a · 2023-09-14T20:49:07.000+02:00
Co-authored-by: Davis Goodin &lt;dagood@users.noreply.github.com&gt;
diff --git a/tls1prf.go b/tls1prf.go
@@ -94,7 +94,9 @@ func TLS1PRF(result, secret, label, seed []byte, h func() hash.Hash) error {
 		return newOpenSSLError("EVP_PKEY_derive")
 	}
 	// The Go standard library expects TLS1PRF to return the requested number of bytes,
-	// fail if it doesn't.
+	// fail if it doesn't. While there is no known situation where this will happen,
+	// EVP_PKEY_derive handles multiple algorithms and there could be a subtle mismatch
+	// after more code changes in the future.
 	if outLen != C.size_t(len(result)) {
 		return errors.New("tls1-prf: derived less bytes than requested")
 	}

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,9 @@ func TLS1PRF(result, secret, label, seed []byte, h func() hash.Hash) error {`
`94`	`94`	`return newOpenSSLError("EVP_PKEY_derive")`
`95`	`95`	`}`
`96`	`96`	`// The Go standard library expects TLS1PRF to return the requested number of bytes,`
`97`		`- // fail if it doesn't.`
	`97`	`+ // fail if it doesn't. While there is no known situation where this will happen,`
	`98`	`+ // EVP_PKEY_derive handles multiple algorithms and there could be a subtle mismatch`
	`99`	`+ // after more code changes in the future.`
`98`	`100`	`if outLen != C.size_t(len(result)) {`
`99`	`101`	`return errors.New("tls1-prf: derived less bytes than requested")`
`100`	`102`	`}`