Skip to content

Commit 41f3495

Browse files
committed
fix: Conform to go test naming convention
As reported in #835 go vet reporting the violation of naming convention of go test. see: https://pkg.go.dev/testing#hdr-Examples Although this project use golangci-lint as linter and it has functionality to skip by nolint:govet, so basically there is no problems. However if there is no cons, it is better to conform with naming convention and fix the code like below. https://github.com/golang-migrate/migrate/blob/c367ed2f12b8549c2ace442c440a9e312348951d/dktesting/example_test.go#L17
1 parent c367ed2 commit 41f3495

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

testing/testing_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ import (
44
"testing"
55
)
66

7-
func ExampleParallelTest(t *testing.T) { // nolint:govet
7+
func ExampleParallelTest() {
8+
t := &testing.T{} // Should actually be used in a Test
9+
810
var isReady = func(i Instance) bool {
911
// Return true if Instance is ready to run tests.
1012
// Don't block here though.

0 commit comments

Comments
 (0)