Skip to content

Commit 5582a20

Browse files
committed
style(yugabyte): simplify error conditions
1 parent bf926fa commit 5582a20

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

database/yugabytedb/yugabytedb.go

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -421,16 +421,20 @@ func (c *YugabyteDB) doTxWithRetry(
421421
//nolint:errcheck
422422
defer tx.Rollback()
423423

424-
if err := fn(tx); err != nil && !errIsRetryable(err) {
424+
if err := fn(tx); err != nil {
425+
if errIsRetryable(err) {
426+
return err
427+
}
428+
425429
return backoff.Permanent(err)
426-
} else if err != nil {
427-
return err
428430
}
429431

430-
if err := tx.Commit(); err != nil && !errIsRetryable(err) {
432+
if err := tx.Commit(); err != nil {
433+
if errIsRetryable(err) {
434+
return err
435+
}
436+
431437
return backoff.Permanent(err)
432-
} else if err != nil {
433-
return err
434438
}
435439

436440
return nil

0 commit comments

Comments
 (0)