Use t.Skipf() per golangci-lint (gosimple)

dhui · dhui · commit acc11eda6d26 · 2022-05-13T15:59:07.000-07:00
diff --git a/database/sqlserver/sqlserver_test.go b/database/sqlserver/sqlserver_test.go
@@ -91,7 +91,7 @@ func isReady(ctx context.Context, c dktest.ContainerInfo) bool {
 
 func SkipIfUnsupportedArch(t *testing.T, c dktest.ContainerInfo) {
 	if strings.Contains(c.ImageName, "mssql") && !strings.HasPrefix(runtime.GOARCH, "amd") {
-		t.Skip(fmt.Sprintf("Image %s is not supported on arch %s", c.ImageName, runtime.GOARCH))
+		t.Skipf("Image %s is not supported on arch %s", c.ImageName, runtime.GOARCH)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func isReady(ctx context.Context, c dktest.ContainerInfo) bool {`
`91`	`91`
`92`	`92`	`func SkipIfUnsupportedArch(t *testing.T, c dktest.ContainerInfo) {`
`93`	`93`	`if strings.Contains(c.ImageName, "mssql") && !strings.HasPrefix(runtime.GOARCH, "amd") {`
`94`		`- t.Skip(fmt.Sprintf("Image %s is not supported on arch %s", c.ImageName, runtime.GOARCH))`
	`94`	`+ t.Skipf("Image %s is not supported on arch %s", c.ImageName, runtime.GOARCH)`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`