Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Commit 7d21ee7

Browse files
committed
Add info msg ensure -v when first step is in sync
1 parent 42ef91d commit 7d21ee7

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

cmd/dep/ensure.go

+13-4
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,10 @@ func (cmd *ensureCommand) runDefault(ctx *dep.Ctx, args []string, p *dep.Project
239239
return nil
240240
}
241241

242+
if ctx.Verbose {
243+
ctx.Out.Printf("%s was already in sync with imports and %s, recreating vendor/ directory", dep.LockName, dep.ManifestName)
244+
}
245+
242246
// TODO(sdboyer) The desired behavior at this point is to determine
243247
// whether it's necessary to write out vendor, or if it's already
244248
// consistent with the lock. However, we haven't yet determined what
@@ -385,12 +389,17 @@ func (cmd *ensureCommand) runAdd(ctx *dep.Ctx, args []string, p *dep.Project, sm
385389
return errors.Errorf("%s and %s are out of sync. Run a plain dep ensure to resync them before attempting to -add", dep.ManifestName, dep.LockName)
386390
}
387391

388-
rm, errmap := params.RootPackageTree.ToReachMap(true, true, false, p.Manifest.IgnoredPackages())
392+
rm, _ := params.RootPackageTree.ToReachMap(true, true, false, p.Manifest.IgnoredPackages())
393+
394+
// TODO(sdboyer) re-enable this once we ToReachMap() intelligently filters out normally-excluded (_*, .*), dirs from errmap
395+
//rm, errmap := params.RootPackageTree.ToReachMap(true, true, false, p.Manifest.IgnoredPackages())
389396
// Having some problematic internal packages isn't cause for termination,
390397
// but the user needs to be warned.
391-
for fail := range errmap {
392-
ctx.Err.Printf("Warning: %s", fail)
393-
}
398+
//for fail, err := range errmap {
399+
//if _, is := err.Err.(*build.NoGoError); !is {
400+
//ctx.Err.Printf("Warning: %s, %s", fail, err)
401+
//}
402+
//}
394403

395404
// Compile unique sets of 1) all external packages imported or required, and
396405
// 2) the project roots under which they fall.

0 commit comments

Comments
 (0)