Skip to content

Commit 5fce1d9

Browse files
committed
runtime: disable TestSegv panic check on darwin, illumos, solaris
CL 339990 made this test more strict, exposing pre-existing issues on these OSes. Skip for now until they can be resolved. Updates #49182 Change-Id: I3ac400dcd21b801bf4ab4eeb630e23b5c66ba563 Reviewed-on: https://go-review.googlesource.com/c/go/+/359254 Trust: Michael Pratt <[email protected]> Run-TryBot: Michael Pratt <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> TryBot-Result: Go Bot <[email protected]>
1 parent 6f0185b commit 5fce1d9

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/runtime/crash_cgo_test.go

+11-3
Original file line numberDiff line numberDiff line change
@@ -625,10 +625,18 @@ func TestSegv(t *testing.T) {
625625
if !strings.Contains(got, want) {
626626
t.Errorf("did not see %q in output", want)
627627
}
628+
628629
// No runtime errors like "runtime: unknown pc".
629-
nowant := "runtime: "
630-
if strings.Contains(got, nowant) {
631-
t.Errorf("unexpectedly saw %q in output", want)
630+
switch runtime.GOOS {
631+
case "darwin", "illumos", "solaris":
632+
// TODO(golang.org/issue/49182): Skip, runtime
633+
// throws while attempting to generate
634+
// traceback.
635+
default:
636+
nowant := "runtime: "
637+
if strings.Contains(got, nowant) {
638+
t.Errorf("unexpectedly saw %q in output", nowant)
639+
}
632640
}
633641
})
634642
}

0 commit comments

Comments
 (0)