x/tools/gopls/internal/test/marker: test holds open temp files after it has finished (windows)

[gopherbot]

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/references\\issue59851.txt"

Issue created automatically to collect these failures.

Example (log):

=== RUN   Test/references\issue59851.txt
=== PAUSE Test/references\issue59851.txt
=== CONT  Test/references\issue59851.txt
    testing.go:1232: TempDir RemoveAll cleanup: remove C:\b\s\w\ir\x\t\Testreferencesissue59851.txt4078840582\001\work: The process cannot access the file because it is being used by another process.
--- FAIL: Test/references\issue59851.txt (36.42s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test/references\\issue59851.txt"

2025-02-03 16:44 x_tools-go1.22-windows-amd64-longtest tools@269282df release-branch.go1.22@0cc45e7c x/tools/gopls/internal/test/marker.Test/references\issue59851.txt (log)

=== RUN   Test/references\issue59851.txt
=== PAUSE Test/references\issue59851.txt
=== CONT  Test/references\issue59851.txt
    testing.go:1232: TempDir RemoveAll cleanup: remove C:\b\s\w\ir\x\t\Testreferencesissue59851.txt4078840582\001\work: The process cannot access the file because it is being used by another process.
--- FAIL: Test/references\issue59851.txt (36.42s)

— watchflakes

[adonovan]

Related:

• cmd/go: "cannot access the file because it is being used by another process" flakes on Windows #71112 (perhaps go list has some asynchronous subprocess?)
• cmd/go: TestScript failures #66337
• x/tools/go/packages: TestAdHocContains failures with The process cannot access the file because it is being used by another process #58708

These problems seem to predate x/telemetry, so I doubt the telemetry subprocess can be (solely) to blame.

[gopherbot]

Change https://go.dev/cl/647516 mentions this issue: go/packages: add test that go list closes file handles