x/tools/gopls: SEGV updating non-nil map in analysis.Validate

[adonovan]

#!stacks
"sigpanic" && "mapassign_fast64ptr" && "analysis.Validate:+86"

Issue created by stacks.

More obvious memory corruption.

This stack SBwKJw was reported by telemetry:

• crash/crash
• runtime.throw:+9
• runtime.sigpanic:+33
• runtime.mapassign_fast64ptr:+34
• golang.org/x/tools/go/analysis.Validate:+86
• golang.org/x/tools/gopls/internal/cache.(*Snapshot).Analyze:+35
• golang.org/x/tools/gopls/internal/golang.Analyze:+7
• golang.org/x/tools/gopls/internal/server.(*server).diagnose.func6:+5
• runtime.goexit:+0

golang.org/x/tools/[email protected] go1.23.8 linux/amd64 vscode (1)

[gabyhelp]

Related Issues

• x/tools/gopls: SEGV accessing map[string]... #73387
• x/tools/gopls: impossible crash in persistent.Map decref #72931
• x/tools/gopls: SEGV while clearing memory in newobject #71561
• x/tools/gopls: panic in analysis #60551 (closed)
• x/tools/gopls: panic during internal/cache.(*analysisNode).typeCheck (crash) #67595 (closed)
• x/tools/gopls: sigpanic in persistent.(*mapNode).forEach (bad SP) #71115
• x/tools/gopls: panic in aeshashbody on behalf of mapaccess2_faststr: string memory corrupted #71367
• x/tools/gopls: analysisinternal.ZeroValue crash on (presumably) unsafe.Pointer #70585 (closed)
• x/tools/gopls: crash in analysisNode.typeCheck #64227 (closed)
• x/tools/gopls: type assertion panics in persistent.Map.Get #72027

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}