Skip to content

Commit 50dca8f

Browse files
changkunhyangah
authored andcommitted
cmd/gomobile: tidy a few unused code and variables
Change-Id: I979589adf74ec0cd097ef7acc6c120f6557c8f25 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/369201 Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: David Chase <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
1 parent ce6a79c commit 50dca8f

File tree

3 files changed

+3
-28
lines changed

3 files changed

+3
-28
lines changed

cmd/gomobile/build.go

-5
Original file line numberDiff line numberDiff line change
@@ -271,11 +271,6 @@ func addBuildFlagsNVXWork(cmd *command) {
271271
cmd.flag.BoolVar(&buildWork, "work", false, "")
272272
}
273273

274-
type binInfo struct {
275-
hasPkgApp bool
276-
hasPkgAL bool
277-
}
278-
279274
func init() {
280275
addBuildFlags(cmdBuild)
281276
addBuildFlagsNVXWork(cmdBuild)

cmd/gomobile/env.go

+3-7
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,9 @@ import (
1414

1515
// General mobile build environment. Initialized by envInit.
1616
var (
17-
gomobilepath string // $GOPATH/pkg/gomobile
18-
19-
androidEnv map[string][]string // android arch -> []string
20-
21-
appleEnv map[string][]string
22-
23-
androidArmNM string
17+
gomobilepath string // $GOPATH/pkg/gomobile
18+
androidEnv map[string][]string // android arch -> []string
19+
appleEnv map[string][]string
2420
appleNM string
2521
)
2622

cmd/gomobile/init.go

-16
Original file line numberDiff line numberDiff line change
@@ -208,12 +208,6 @@ func installOpenAL(gomobilepath string) error {
208208
return nil
209209
}
210210

211-
var commonPkgs = []string{
212-
"golang.org/x/mobile/gl",
213-
"golang.org/x/mobile/app",
214-
"golang.org/x/mobile/exp/app/debug",
215-
}
216-
217211
func mkdir(dir string) error {
218212
if buildX || buildN {
219213
printcmd("mkdir -p %s", dir)
@@ -237,16 +231,6 @@ func symlink(src, dst string) error {
237231
return os.Symlink(src, dst)
238232
}
239233

240-
func rm(name string) error {
241-
if buildX || buildN {
242-
printcmd("rm %s", name)
243-
}
244-
if buildN {
245-
return nil
246-
}
247-
return os.Remove(name)
248-
}
249-
250234
func doCopyAll(dst, src string) error {
251235
return filepath.Walk(src, func(path string, info os.FileInfo, errin error) (err error) {
252236
if errin != nil {

0 commit comments

Comments
 (0)