deploy,devtools: upgrade to go1.20rc3

- Disabled staticcheck while go1.20 is unsupported.
- Fixed out of bounds error in doc html parsing.
- Fixed test issue related to rand package changes.

Change-Id: Ib7b30ed9c40505a5a51d986426f0e41e53a298b1
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/464296
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Jamal Carvalho <[email protected]>

Author: jamalc

all.bash

@@ -149,7 +149,8 @@ check_vet() {
 # check_staticcheck runs staticcheck on source files.
 check_staticcheck() {
  ensure_go_binary honnef.co/go/tools/cmd/staticcheck
- runcmd staticcheck $(go list ./... | grep -v third_party | grep -v internal/doc | grep -v internal/render)
+#  runcmd staticcheck $(go list ./... | grep -v third_party | grep -v internal/doc | grep -v internal/render)
+  echo "disabling staticcheck until go1.20 is supported"
 }
 
 # check_misspell runs misspell on source files.

deploy/deploy-env.yaml

@@ -22,7 +22,7 @@ steps:
     args:
       - $PROJECT_ID
   - id: Check redistributable
-    name: golang:1.19
+    name: golang:1.20rc3
     entrypoint: private/devtools/check_redist.sh
   - id: Build
     name: gcr.io/cloud-builders/docker
@@ -48,7 +48,7 @@ steps:
       - -c
       - deploy/frontend.sh $_ENV gcr.io/$PROJECT_ID/frontend:$(cat _BUILD_TAG)
   - id: Pagecheck
-    name: golang:1.19
+    name: golang:1.20rc3
     entrypoint: deploy/pagecheck.sh
     args:
       - $_ENV

deploy/deploy.yaml

@@ -22,7 +22,7 @@ steps:
     args:
       - $PROJECT_ID
   - id: Check redistributable
-    name: golang:1.19
+    name: golang:1.20rc3
     entrypoint: private/devtools/check_redist.sh
   - id: Build
     name: gcr.io/cloud-builders/docker
@@ -48,7 +48,7 @@ steps:
       - -c
       - deploy/frontend.sh staging gcr.io/$PROJECT_ID/frontend:$(cat _BUILD_TAG)
   - id: Pagecheck - staging
-    name: golang:1.19
+    name: golang:1.20rc3
     entrypoint:  deploy/pagecheck.sh
     args:
       - staging
@@ -77,7 +77,7 @@ steps:
       - -c
       - deploy/frontend.sh prod gcr.io/$PROJECT_ID/frontend:$(cat _BUILD_TAG)
   - id: Pagecheck - prod
-    name: golang:1.19
+    name: golang:1.20rc3
     entrypoint:  deploy/pagecheck.sh
     args:
       - prod
@@ -88,7 +88,7 @@ steps:
       - -c
       - deploy/frontend.sh beta gcr.io/$PROJECT_ID/frontend:$(cat _BUILD_TAG)
   - id: Pagecheck - beta
-    name: golang:1.19
+    name: golang:1.20rc3
     entrypoint:  deploy/pagecheck.sh
     args:
       - beta

deploy/migrate.yaml

@@ -16,7 +16,7 @@ steps:
     args:
       - $PROJECT_ID
   - id: Migrate
-    name: golang:1.19
+    name: golang:1.20rc3
     entrypoint: bash
     dir: private
     args:

deploy/sitemap.yaml

@@ -9,7 +9,7 @@ steps:
     args:
       - $PROJECT_ID
   - id: Build
-    name: golang:1.19
+    name: golang:1.20rc3
     entrypoint: bash
     dir: private
     args:

devtools/docker/compose.yaml

@@ -31,7 +31,7 @@ services:
     depends_on:
       - db
      # This should match the version we are using on Cloud Run.
-    image: golang:1.19
+    image: golang:1.20rc3
     environment:
       <<: *database-variables
       <<: *go-variables
@@ -44,7 +44,7 @@ services:
       - ../../:/pkgsite
     working_dir: /pkgsite
   searchtest:
-    image: golang:1.19
+    image: golang:1.20rc3
     depends_on:
       - frontend
     environment:
@@ -57,7 +57,7 @@ services:
       - ../../:/pkgsite
     working_dir: /pkgsite
   api:
-    image: golang:1.19
+    image: golang:1.20rc3
     depends_on:
       - frontend
     environment:
@@ -70,7 +70,7 @@ services:
     working_dir: /pkgsite
   frontend:
      # This should match the version we are using on AppEngine.
-    image: golang:1.19
+    image: golang:1.20rc3
     depends_on:
       - db
     command: bash -c "
@@ -89,7 +89,7 @@ services:
     working_dir: /pkgsite
   seeddb:
      # This should match the version we are using on Cloud Run.
-    image: golang:1.19
+    image: golang:1.20rc3
     depends_on:
       - db
     # Note: technically we should check that migrations have completed before
@@ -142,7 +142,7 @@ services:
     shm_size: 8G
   go:
      # This should match the version we are using on Cloud Run.
-    image: golang:1.19
+    image: golang:1.20rc3
     entrypoint: go
     environment:
       <<: *database-variables

internal/godoc/dochtml/internal/render/linkify.go

@@ -612,7 +612,9 @@ scan:
 		line := file.Line(p) - 1 // current 0-indexed line number
 		offset := file.Offset(p) // current offset into source file
 		tokType := codeType      // current token type (assume source code)
-
+		if lastOffset > offset {
+			continue
+		}
 		// Add traversed bytes from src to the appropriate line.
 		prevLines := strings.SplitAfter(string(src[lastOffset:offset]), "\n")
 		for i, ln := range prevLines {

internal/middleware/experiment_test.go

@@ -77,6 +77,8 @@ func TestSetAndLoadExperiments(t *testing.T) {
 }
 
 func TestShouldSetExperiment(t *testing.T) {
+	// Force the pre-go1.20 behavior of rand.Seed
+	rand.Seed(1)
 	ipv4Addr := func() string {
 		a := make([]string, 4)
 		for i := 0; i < 4; i++ {