Skip to content

Commit 56ec111

Browse files
committed
gopls/internal/server: remove spurious Async in legacy RunGoVulncheck
In the partial rollback CL 627556, I failed to remove the call to jsonrpc2.Async in RunGoVulncheck, which is now (once again) async to request handling. This introduces a race, leading to a panic if the handler responds before the call to Async. Fixes golang/go#70355 Change-Id: I8b33599a3f62b82dc6acf9d9b3616194c0372b9c Reviewed-on: https://go-review.googlesource.com/c/tools/+/628236 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent b1c39aa commit 56ec111

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

gopls/internal/server/command.go

-2
Original file line numberDiff line numberDiff line change
@@ -1294,8 +1294,6 @@ func (c *commandHandler) RunGovulncheck(ctx context.Context, args command.Vulnch
12941294
}, func(ctx context.Context, deps commandDeps) error {
12951295
tokenChan <- deps.work.Token()
12961296

1297-
jsonrpc2.Async(ctx) // run this in parallel with other requests: vulncheck can be slow.
1298-
12991297
workDoneWriter := progress.NewWorkDoneWriter(ctx, deps.work)
13001298
dir := filepath.Dir(args.URI.Path())
13011299
pattern := args.Pattern

0 commit comments

Comments
 (0)