Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/present: support sub-section headings #6846

Open
gopherbot opened this issue Nov 29, 2013 · 13 comments · May be fixed by golang/tools#238
Open

x/tools/present: support sub-section headings #6846

gopherbot opened this issue Nov 29, 2013 · 13 comments · May be fixed by golang/tools#238
Labels
help wanted
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

by sathishvj:

go version 1.2rc5

Multiple issues with sub sections in go.talks/present.  Please see attached partial
screenshot.

* A subsection has a title numbering system that a section does not have
* Size and formatting of sub section is much larger than section
* Content under subsection is not showing
* 2 subsections overwrite one another

priority: low, but still would be nice to get done sometime.

Attachments:

  1. go.talks-present subsection issues.png (110139 bytes)
@dsymonds
Copy link
Contributor

dsymonds commented Dec 2, 2013

Comment 1:

Owner changed to @adg.

@adg
Copy link
Contributor

adg commented Dec 2, 2013

Comment 2:

Subsections are not really supposed to be used in slides. (At least, they were never
intended for this.)

Labels changed: added priority-someday, norelease, removed priority-triage, go1.3maybe.

@gopherbot
Copy link
Contributor Author

Comment 3 by sathishvj:

If 'sub section' was meant to be a different section, then at least it should start on a
new page, shouldn't it?  Either ways, it appears either wrong or confusing to me.
p.s. am doing a short video for the community on how to create these slides, so thought
I'll report things that I didn't understand.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added repo-talks.

@rsc
Copy link
Contributor

rsc commented Mar 3, 2014

Comment 5:

Adding Release=None to all Priority=Someday bugs.

Labels changed: added release-none.

@gopherbot
Copy link
Contributor Author

Comment 6 by ssendilkumar:

Can anyone point how to create sub bullets ?

@bradfitz bradfitz removed new labels Dec 18, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title go.talks/present: Sub section headings are messed up x/talks/present: Sub section headings are messed up Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-talks label Apr 14, 2015
@adg adg changed the title x/talks/present: Sub section headings are messed up x/talks/present: support sub-section headings Aug 27, 2015
@adg adg mentioned this issue Aug 27, 2015
Closed
@adg adg removed their assignment May 27, 2016
@adg adg mentioned this issue May 27, 2016
Closed
@bronger
Copy link

bronger commented Oct 21, 2016

https://godoc.org/golang.org/x/tools/present says that subsections are possible. Maybe this should be removed, at least for the time being.

@fuweid
Copy link
Contributor

fuweid commented May 3, 2017

Hi @adg , I get started to use cmd/present. Follow the doc and found the same issue.

I found that the h2 section has different attributes from h1/h3.

position: absolute;
bottom: 150px;

I checked the commit history and don't know why add "position: absolute" here. Can you explain this, please? Thank you

@adg
Copy link
Contributor

adg commented May 6, 2017 via email

@fuweid
Copy link
Contributor

fuweid commented May 11, 2017

all right...Thank you

@kaushalmodi
Copy link

I just tried out present and was surprised to see this anomaly with the display of subsections. I was simply following the example in the official go present documentation.

It's discouraging to see this bug is 4 years old!! If no one knows how to fix it, isn't it easy to just fix the documentation?

Is go present end of life/not maintained?

@dmitshur dmitshur changed the title x/talks/present: support sub-section headings x/tools/present: support sub-section headings Mar 10, 2018
@shuLhan
Copy link
Contributor

shuLhan commented Nov 19, 2018

What does the suggested solution for this issue? Maybe if it does not need a proposal, I may want to look into it.

@AndersonQ
Copy link
Contributor

Hi, I see that the problem persists and this issue looks dead. I'll try to investigate

FilipNikolovski added a commit to FilipNikolovski/tools that referenced this issue Jun 25, 2020
@FilipNikolovski
present: properly render section heading using the section's level nu…
b56102b 
…mber

This fixes golang/go#6846

If we take the example from the readme:

Some Text

- bullets
- more bullets
- a bullet continued
  on the next line

Some More text

	Preformatted text (code block)
	is indented (by one tab, or four spaces)

The sub-section and sub-subsection will have the headings <h2> and <h3> respectively,
which breaks the page, since the main title has a heading of <h3> so it pushes down the sub-section to
the bottom of the page.

If we use .Level for the section heading, they will have the headings <h3> and <h4> which will render properly.
@FilipNikolovski FilipNikolovski linked a pull request Jun 25, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

present: properly render sub-section heading FilipNikolovski/tools
10 participants
@bradfitz @dsymonds @shuLhan @rsc @AndersonQ @bronger @kaushalmodi @adg @gopherbot @fuweid