Skip to content

Commit 3f589fd

Browse files
rawen17ldez
authored andcommitted
add nakedefer linter - fix bugs
1 parent d500dc5 commit 3f589fd

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ require (
1111
github.com/BurntSushi/toml v1.2.1
1212
github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
1313
github.com/GaijinEntertainment/go-exhaustruct/v2 v2.3.0
14-
github.com/GaijinEntertainment/go-nakedefer v1.4.0
14+
github.com/GaijinEntertainment/go-nakedefer v1.4.0
1515
github.com/OpenPeeDeeP/depguard v1.1.1
1616
github.com/alexkohler/prealloc v1.0.0
1717
github.com/alingse/asasalint v0.0.11

test/testdata/configs/nakedefer.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
linters-settings:
22
nakedefer:
3-
exclude: os\.(Create|WriteFile|Chmod),fmt\.Print.*,io\.Close
3+
exclude: os\.(Create|WriteFile|Chmod),fmt\.Print.*,io\.Close,ignoreFunc

test/testdata/nakedefer.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ func ignoreFunc() error {
3232
func testCaseValid1() {
3333
defer funcNotReturnAnyType() // ignore
3434

35-
defer func() { //ignore
35+
defer func() { // ignore
3636
funcNotReturnAnyType()
3737
}()
3838

39-
defer func() { //ignore
39+
defer func() { // ignore
4040
_ = funcReturnErr()
4141
}()
4242
}
@@ -65,8 +65,8 @@ func testCase1() {
6565
w.WriteHeader(http.StatusOK)
6666
_, _ = w.Write([]byte("DONE"))
6767
}))
68-
defer srv.Close() //ignore
69-
defer srv.CloseClientConnections() //ignore
68+
defer srv.Close() // ignore
69+
defer srv.CloseClientConnections() // ignore
7070
defer srv.Certificate() // want "deferred call should not return anything"
7171
}
7272

0 commit comments

Comments
 (0)