Merge branch 'master' into adddefer

Author: alexandear

Diff for: .github/workflows/post-release.yml

@@ -18,7 +18,7 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: 1.19
+          go-version: '1.20'
 
       - name: Update GitHub action config
         run: make assets/github-action-config.json

Diff for: .github/workflows/pr-extra.yml

@@ -17,7 +17,7 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: 1.19
+          go-version: '1.20'
       - name: Run go list
         run: go list -json -m all > go.list
       - name: Nancy

Diff for: .github/workflows/pr.yml

@@ -6,7 +6,7 @@ on:
   pull_request:
 
 env:
-  GO_VERSION: 1.19
+  GO_VERSION: '1.20'
 
 jobs:
   # Check if there is any dirty change for go mod tidy
@@ -43,7 +43,7 @@ jobs:
           # - 1.18rc1 -> 1.18.0-rc.1
           go-version: ${{ env.GO_VERSION }}
       - name: lint
-        uses: golangci/golangci-lint-action@v3.3.1
+        uses: golangci/golangci-lint-action@v3.4.0
         with:
           version: latest
           # skip cache because of flaky behaviors
@@ -88,8 +88,8 @@ jobs:
     strategy:
       matrix:
         golang:
-          - 1.18
           - 1.19
+          - '1.20'
     steps:
       - uses: actions/checkout@v3
       - name: Install Go

Diff for: .github/workflows/tag.yml

@@ -18,7 +18,7 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: 1.19
+          go-version: '1.20'
       - name: Unshallow
         run: git fetch --prune --unshallow
 
@@ -48,7 +48,7 @@ jobs:
           # ex:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
-          go-version: 1.19
+          go-version: '1.20'
 
       - name: Unshallow
         run: git fetch --prune --unshallow
@@ -60,18 +60,18 @@ jobs:
           MAJOR=${TAG%.*}
           SHORT_COMMIT=${GITHUB_SHA::8}
           DATE=$(date '+%Y-%m-%dT%H:%M:%SZ')
-          echo ::set-output name=tag_name::${TAG}
-          echo ::set-output name=major_tag::${MAJOR}
-          echo ::set-output name=short_commit::${SHORT_COMMIT}
-          echo ::set-output name=date::${DATE}
+          echo tag_name=${TAG} >> $GITHUB_OUTPUT
+          echo major_tag=${MAJOR} >> $GITHUB_OUTPUT
+          echo short_commit=${SHORT_COMMIT} >> $GITHUB_OUTPUT
+          echo date=${DATE} >> $GITHUB_OUTPUT
           if [[ ${{ matrix.target.Dockerfile }} == *"alpine"* ]]; then
-            echo ::set-output name=full_tag_name::${TAG}-alpine
-            echo ::set-output name=full_major_tag::${MAJOR}-alpine
-            echo ::set-output name=latest_tag::latest-alpine
+            echo full_tag_name=${TAG}-alpine >> $GITHUB_OUTPUT
+            echo full_major_tag=${MAJOR}-alpine >> $GITHUB_OUTPUT
+            echo latest_tag=latest-alpine >> $GITHUB_OUTPUT
           else
-            echo ::set-output name=full_tag_name::${TAG}
-            echo ::set-output name=full_major_tag::${MAJOR}
-            echo ::set-output name=latest_tag::latest
+            echo full_tag_name=${TAG} >> $GITHUB_OUTPUT
+            echo full_major_tag=${MAJOR} >> $GITHUB_OUTPUT
+            echo latest_tag=latest >> $GITHUB_OUTPUT
           fi
 
       - name: Set up QEMU
@@ -84,7 +84,7 @@ jobs:
         run: docker login -u golangci -p ${{ secrets.GOLANGCI_LINT_DOCKER_TOKEN }}
 
       - name: Build and publish ${{ matrix.target.Dockerfile }}
-        uses: docker/build-push-action@v3
+        uses: docker/build-push-action@v4
         with:
           context: .
           file: ${{ matrix.target.Dockerfile }}

Diff for: .golangci.reference.yml

@@ -80,7 +80,7 @@ output:
   # Multiple can be specified by separating them by comma, output can be provided
   # for each of them by separating format name and path by colon symbol.
   # Output path can be either `stdout`, `stderr` or path to the file to write to.
-  # Example: "checkstyle:report.json,colored-line-number"
+  # Example: "checkstyle:report.xml,json:stdout,colored-line-number"
   #
   # Default: colored-line-number
   format: json
@@ -1394,6 +1394,13 @@ linters-settings:
         severity: warning
         disabled: false
         arguments: [ 7 ]
+      # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#comment-spacings
+      - name: comment-spacings
+        severity: warning
+        disabled: false
+        arguments:
+          - mypragma
+          - otherpragma
       # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#confusing-naming
       - name: confusing-naming
         severity: warning
@@ -1800,7 +1807,7 @@ linters-settings:
     # Suggest the use of rpc.DefaultXXPath.
     # Default: false
     default-rpc-path: true
-    # Suggest the use of os.DevNull.
+    # DEPRECATED Suggest the use of os.DevNull.
     # Default: false
     os-dev-null: true
     # Suggest the use of sql.LevelXX.String().
@@ -1812,7 +1819,7 @@ linters-settings:
     # Suggest the use of constant.Kind.String().
     # Default: false
     constant-kind: true
-    # Suggest the use of syslog.Priority.
+    # DEPRECATED Suggest the use of syslog.Priority.
     # Default: false
     syslog-priority: true
 
@@ -1924,48 +1931,48 @@ linters-settings:
     # this is set to true - the append call must append either a variable
     # assigned, called or used on the line above.
     strict-append: true
-    
+
     # Allows assignments to be cuddled with variables used in calls on
     # line above and calls to be cuddled with assignments of variables
     # used in call on line above.
     allow-assign-and-call: true
-    
+
     # Allows assignments to be cuddled with anything.
     allow-assign-and-anything: false
-    
+
     # Allows cuddling to assignments even if they span over multiple lines.
     allow-multiline-assign: true
-    
+
     # If the number of lines in a case block is equal to or lager than this
     # number, the case *must* end white a newline.
     force-case-trailing-whitespace: 0
-    
+
     # Allow blocks to end with comments.
     allow-trailing-comment: false
-    
+
     # Allow multiple comments in the beginning of a block separated with newline.
     allow-separated-leading-comment: false
-    
+
     # Allow multiple var/declaration statements to be cuddled.
     allow-cuddle-declarations: false
-    
+
     # A list of call idents that everything can be cuddled with.
     # Defaults to calls looking like locks.
     allow-cuddle-with-calls: [ "Lock", "RLock" ]
-    
+
     # AllowCuddleWithRHS is a list of right hand side variables that is allowed
     # to be cuddled with anything. Defaults to assignments or calls looking
     # like unlocks.
     allow-cuddle-with-rhs: [ "Unlock", "RUnlock" ]
-    
+
     # Causes an error when an If statement that checks an error variable doesn't
     # cuddle with the assignment of that variable.
     force-err-cuddling: false
-    
+
     # When force-err-cuddling is enabled this is a list of names
     # used for error variables to check for in the conditional.
     error-variable-names: [ "err" ]
-    
+
     # Causes an error if a short declaration (:=) cuddles with anything other than
     # another short declaration.
     # This logic overrides force-err-cuddling among others.

Diff for: .golangci.yml

@@ -135,6 +135,8 @@ issues:
       text: "SA1019: settings.GoVersion is deprecated: use the global `run.go` instead."
     - path: pkg/lint/lintersdb/manager.go
       text: "SA1019: (.+).(GoVersion|LangVersion) is deprecated: use the global `run.go` instead."
+    - path: pkg/golinters/unused.go
+      text: "rangeValCopy: each iteration copies 160 bytes \\(consider pointers or indexing\\)"
 
 run:
   timeout: 5m

Diff for: .goreleaser.yml

@@ -73,6 +73,10 @@ changelog:
       - Merge pull request
       - Merge branch
 
+source:
+  enabled: true
+  name_template: '{{ .ProjectName }}-{{ .Version }}-source'
+
 brews:
   - tap:
       owner: golangci

Diff for: CHANGELOG.md

@@ -1,6 +1,84 @@
 Follow the news and releases on our [twitter](https://twitter.com/golangci) and our [blog](https://medium.com/golangci).
 There is the most valuable changes log:
 
+### v1.51.2
+
+1. updated linters
+   * `forbidigo`: from 1.3.0 to 1.4.0
+   * `gci`: from 0.9.0 to 0.9.1
+   * `go-critic`: from 0.6.5 to 0.6.7
+   * `go-errorlint`: from 1.0.6 to 1.1.0
+   * `gosec`: from 2.14.0 to 2.15.0
+   * `musttag`: from 0.4.4 to 0.4.5
+   * `staticcheck`: from 0.4.0 to 0.4.2
+   * `tools`: from 0.5.0 to 0.6.0
+   * `usestdlibvars`: from 1.21.1 to 1.23.0
+   * `wsl`: from 3.3.0 to 3.4.0
+   * `govet`: enable `timeformat` by default
+2. misc.
+   * fix: cache status size calculation
+   * add new source archive
+3. Documentation
+   * Improve installation section
+   * Replace links to godoc.org with pkg.go.dev
+
+### v1.51.1
+
+1. updated linters
+   * `ginkgolinter`: from 0.7.1 to 0.8.1
+   * `ineffassign`: bump to HEAD
+   * `musttag`: from 0.4.3 to 0.4.4
+   * `sqlclosecheck`: from 0.3.0 to 0.4.0
+   * `staticcheck`: bump to v0.4.0
+   * `wastedassign`: from 2.0.6 to 2.0.7
+   * `wrapcheck`: from 2.7.0 to 2.8.0
+
+### v1.51.0
+
+1. new linters
+   * `ginkgolinter`: https://github.com/nunnatsa/ginkgolinter
+   * `musttag`: https://github.com/junk1tm/musttag
+   * `gocheckcompilerdirectives`: https://github.com/leighmcculloch/gocheckcompilerdirectives
+2. updated linters
+   * `bodyclose`: to HEAD
+   * `dupword`: from 0.0.7 to 0.0.9
+   * `errcheck`: from 1.6.2 to 1.6.3
+   * `exhaustive`: from 0.8.3 to 0.9.5
+   * `exportloopref`: from 0.1.8 to 0.1.11
+   * `gci`: from 0.8.1 to 0.9.0
+   * `ginkgolinter`: from 0.6.0 to 0.7.1
+   * `go-errorlint`: from 1.0.5 to 1.0.6
+   * `go-ruleguard`: from 0.3.21 to 0.3.22
+   * `gocheckcompilerdirectives`: from 1.1.0 to 1.2.1
+   * `gochecknoglobals`: from 0.1.0 to 0.2.1
+   * `gomodguard`: from 1.2.4 to 1.3.0
+   * `gosec`: from 2.13.1 to 2.14.0
+   * `govet`: Add `timeformat` to analysers
+   * `grouper`: from 1.1.0 to 1.1.1
+   * `musttag`: from 0.4.1 to 0.4.3
+   * `revive`: from 1.2.4 to 1.2.5
+   * `tagliatelle`: from 0.3.1 to 0.4.0
+   * `tenv`: from 1.7.0 to 1.7.1
+   * `unparam`: bump to HEAD
+   * `usestdlibvars`: from 1.20.0 to 1.21.1
+   * `wsl`: fix `force-err-cuddling` flag
+3. misc.
+   * go1.20 support
+   * remove deprecated linters from presets
+   * Build NetBSD binaries
+   * Build loong64 binaries
+4. Documentation
+   * `goimport`: improve documentation for local-prefixes
+   * `gomnd`: add missing always ignored functions
+   * `nolint`: fix typo
+   * `tagliatelle` usage typo
+   * add note about binary requirement for plugin
+   * cache preserving and colored output on docker runs
+   * improve documentation about debugging.
+   * improve Editor Integration section
+   * More specific default cache directory
+   * update output example to use valid checkstyle example; add json example
+
 ### v1.50.1
 
 1. updated linters

Diff for: CODE_OF_CONDUCT.md

@@ -55,7 +55,7 @@ further defined and clarified by project maintainers.
 ## Enforcement
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at idenx@yandex.com. All
+reported by contacting the project team at info@golangci.com. All
 complaints will be reviewed and investigated and will result in a response that
 is deemed necessary and appropriate to the circumstances. The project team is
 obligated to maintain confidentiality with regard to the reporter of an incident.